Hi!
On Fri, 2014-10-17 at 09:10:39 +0200, Johannes Schauer wrote:
> Package: dpkg
> Version: 1.17.18
> Severity: wishlist
> Tags: patch
> this has not been agreed upon with a wider audience yet, so I'll post
> this just as a proposal and to not loose the patch I attached.
I've just skimmed over the patch, skipped the report body text for now,
and did not sit down to think about possible consequences/problems, etc.
Thanks for the patch!
> diff --git a/scripts/dpkg-checkbuilddeps.pl b/scripts/dpkg-checkbuilddeps.pl
> index 3feba3a..47accc9 100755
> --- a/scripts/dpkg-checkbuilddeps.pl
> +++ b/scripts/dpkg-checkbuilddeps.pl
> @@ -52,6 +52,8 @@ sub usage {
> -c build-conf use given string for build conflicts instead of
> retrieving them from control file
> -a arch assume given host architecture
> + --target-arch=<arch>
> + assume given host architecture
This should be target not host.
Also, wouldn't dpkg-buildpackage need to pass this option to
dpkg-checkbuilddeps?
The rest looks good (as long as it behaves correctly that is :). But it
would be nice to add some unit tests to Dpkg_Deps.t, I've just enabled
very minimal ones for :native.
Thanks,
Guillem
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
