On Wed, 2005-11-30 at 16:10 -0500, Charles Fry wrote: > Hi Alan, > > You may remember me from a previous exchange we had regarding wmfire. > > It ends up that now there are several Debian users of your latest > release that are experiencing new strange failures that didn't happen > before. You can read about their problems at: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=341255 > > Does the behavior that they describe sound familiar to anything that > you've seen before? Do you have any suspicion of what could be causing > this failure, when your previous version worked just fine?
Yes, other people have reported it. Looking at it again today I believe I've have found [1] the problem this time. The fix required for GTK 2.4 moved a XSetWMHints function but I somehow mistakenly changed this to a XSetWMNormalHints function instead. One liner patch attached (which replaces the one I supplied previously). I'll release this as 1.2.3 after I add a sticky option for WM's which don't have a dock. [1] Or refound as oddly the wmfire 1.2.2 at dockapps.org has the correct function?!? -- Alan. "One must never be purposelessnessnesslessness."
diff -ur wmfire-1.2.2/src/wmfire.c wmfire-1.2.2/src/wmfire.c --- wmfire-1.2.2/src/wmfire.c 2004-08-01 15:06:42.000000000 +0100 +++ wmfire-1.2.2/src/wmfire.c 2004-06-27 21:18:20.000000000 +0100 @@ -630,7 +630,7 @@ gdk_window_show(bm.win); /* Moved after gdk_window_show due to change in GTK 2.4 */ - XSetWMNormalHints(GDK_WINDOW_XDISPLAY(bm.win), win, &wmhints); + XSetWMHints(GDK_WINDOW_XDISPLAY(bm.win), win, &wmhints); if (bm.x > 0 || bm.y > 0) gdk_window_move(bm.win, bm.x, bm.y);
signature.asc
Description: This is a digitally signed message part
