Package: checkbot
Version: 1.80-3
Severity: normal
Tags: patch
Checkbot creates a set of pages telling me all the links on my site
are valid, then adds a footer:
| ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
| Page created by *Checkbot 1.80* on _Sat_Nov_1_12:00:58_2014_.
|
| *[Valid XHTML 1.1]*
|
That "Checkbot 1.80" text is a dead link to the old home page.
The "Valid XHTML 1.1" alt text accompanies an image hosted on the
w3c.org servers. This causes the page to contain a broken image link
if I view it while offline; and clicking the button fails because
validator.org can't access http://mypc.localnet/checkbot.html.
Besides, while it's true that the main page is valid according to the
15-year-old XHTML 1.1 standard, the per-server pages are full of
errors, such as unterminated <dt>s and <dd>s.
Even if that was fixed, Checkbot can never guarantee that its output
pages will be valid, since its reports may quote links like
"http://</>" precisely because they're invalid.
My patch updates the homepage link with the new URL and simply throws
out the "valid XHTML" line.
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (990, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 3.17-1-686-pae (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages checkbot depends on:
ii libcrypt-ssleay-perl 0.58-1+b2
ii libhtml-parser-perl 3.71-1+b2
ii libmailtools-perl 2.13-1
ii libtime-duration-perl 1.10-1
ii liburi-perl 1.64-1
ii libwww-perl 6.08-1
ii perl 5.20.1-2
ii perl-modules [libnet-perl] 5.20.1-2
checkbot recommends no packages.
checkbot suggests no packages.
-- no debconf information
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru checkbot-1.80.pristine/checkbot checkbot-1.80/checkbot
--- checkbot-1.80.pristine/checkbot 2008-10-15 13:55:01.000000000 +0100
+++ checkbot-1.80/checkbot 2014-11-01 11:19:27.946777734 +0000
@@ -1339,8 +1339,7 @@
# Return a string containing Checkbot's signature for HTML pages
sub signature {
- return "<hr />\n<p class='signature'>Page created by <a href=\"http://degraaff.org/checkbot/\";>Checkbot $VERSION</a> on <em>" . localtime() . "</em>.</p>\n".
- "<p><a href=\"http://validator.w3.org/check/?uri=referer\";><img src=\"http://www.w3.org/Icons/valid-xhtml11\"; alt=\"Valid XHTML 1.1\" height=\"31\" width=\"88\" /></a></p>".
+ return "<hr />\n<p class='signature'>Page created by <a href=\"http://sourceforge.net/projects/checkbot/\";>Checkbot $VERSION</a> on <em>" . localtime() . "</em>.</p>\n".
"</body></html>";
}
