Hi, On Dienstag, 4. November 2014, Ximin Luo wrote: > OK, I've uploaded a release candidate to mentors, same address as above.
I took a look, and there are two or three problems, though the fix itself is
mostly fine I think :-)
1. bumping the standards version now is often perceived as unwanted noise by
those reviewing the changes to decide whether to let it enter jessie. leave it
now, but next time please only include non-cosmetic changes _if_ you add non
ron-RC fixes at all.
2. your fix for #765156 looks good to me, I just wonder whether in the
following it really should only be 20 and not 40 or 100... are you sure that
safe enough now and in 5 years?
++ for i in xrange(0, 20):
(I think so, as hw gets faster but... maybe 40 is still better as there could
be even slower hw??)
3. there are lot of changes in debian/rules between 1.7-1 and 1.7-2 and
there's no mentioning of those in debian/changelog at all. Is there a bug# for
the problem they are fixing?
> Get well soon!
thanks, I'm on it..! :-)
cheers,
Holger
signature.asc
Description: This is a digitally signed message part.
