Il 05/11/2014 21:29, Jonas Smedegaard ha scritto:
Hi Riccardo,
Quoting Riccardo Magliocchetti (2014-11-05 16:56:45)
Il 27/10/2014 17:44, Riccardo Magliocchetti ha scritto:
Il 25/10/2014 21:28, Jonas Smedegaard ha scritto:
Riccardo Magliocchetti wrote:
Patch 1005_emperor-pg-fix-cflags.patch should have been already
fixed upstream in 7c31b6657ffdbbbe566822fbcdb6cf2eb4b44026 so could
be removed.
Indeed that upstream commit look quite related, but removing patch
1005 cause the build to fail - just tried for 2.0.7-1.
Help investigating what is going on here is appreciated.
Looks like the saner option would be to remove the build hack that
was added for unknown reason, see:
https://github.com/unbit/uwsgi/pull/759
A more conservative patch has been applied to master, so it would be
nice if you can substitute 1005 with [1]. If that works fine for you
i'll ask to have it backported to 2.0.x so you can drop it.
Thanks for trying - unfortunately it fails:
plugins/systemd_logger/systemd_logger.c: In function 'uwsgi_systemd_logger':
plugins/systemd_logger/systemd_logger.c:13:4: error: format not a string
literal and no format arguments [-Werror=format-security]
sd_journal_print(LOG_INFO, base);
^
cc1: all warnings being treated as errors
using profile: debian/buildconf/uwsgi-plugin.ini
detected include path: ['/usr/lib/gcc/x86_64-linux-gnu/4.9/include',
'/usr/local/include', '/usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed',
'/usr/include/x86_64-linux-gnu', '/usr/include']
*** uWSGI building and linking plugin plugins/systemd_logger ***
x86_64-linux-gnu-gcc -pthread -fPIC -shared -o ./systemd_logger_plugin.so -I. -O2 -I. -Wall -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -DUWSGI_HAS_IFADDRS -DUWSGI_ZLIB
-DUWSGI_LOCK_USE_MUTEX -DUWSGI_EVENT_USE_EPOLL -DUWSGI_EVENT_TIMER_USE_TIMERFD -DUWSGI_EVENT_FILEMONITOR_USE_INOTIFY -DUWSGI_PCRE -DUWSGI_ROUTING -DUWSGI_CAP -DUWSGI_UUID
-DUWSGI_VERSION="\"2.0.8-debian\"" -DUWSGI_VERSION_BASE="2" -DUWSGI_VERSION_MAJOR="0" -DUWSGI_VERSION_MINOR="8"
-DUWSGI_VERSION_REVISION="0" -DUWSGI_VERSION_CUSTOM="\"debian\"" -DUWSGI_YAML -DUWSGI_LIBYAML -DUWSGI_JSON -DUWSGI_SSL -I/usr/include/libxml2
-DUWSGI_XML -DUWSGI_XML_LIBXML2 -DUWSGI_PLUGIN_DIR="\".\"" -Dsystemd_logger_plugin=systemd_logger_plugin plugins/systemd_logger/systemd_logger.c -Wl,-z,relro
-lsystemd
*** unable to build systemd_logger plugin ***
Fixed in:
https://github.com/unbit/uwsgi/commit/3406441d9585026cdfeb2d0bc979ad9bf527824d
I've compiled all plugins in master branch so it should be fine in 2.0.x
too. Let me know otherwise. If everything is fine i'll backport the
uwsgiconfig.py patch so with 2.0.9 hopefully we can drop both patches.
thanks,
riccardo
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
