Control: retitle -1 unblock: signing-party/1.1.10-2 unblock signing-party/1.1.10-2
On Fri, 07 Nov 2014 at 23:26:24 +0100, Niels Thykier wrote: > On 2014-11-07 22:36, Guilhem Moulin wrote: >> I would like to upload the attached changes: a regression bug has been >> introduced in signing-party 1.1.10-1, making caff violate RFC 2822 when >> sending messages with a non-English locale. This fixes bug #767371. > > Please do and let us know once it has been accepted in sid. Grmbl, I should have waited the package being accepted before filing that unblock request, actually… The package being native I didn't modifying the source would lead to a REJECT due to conflicting .orig.tar.gz. Sorry for the mess. Anyway, signing-party 1.1.10-2 has just been ACCEPTed in sid. Here is the new debdiff, with version number fixed to 1.1.10-2. Cheers, -- Guilhem.
diff -Nru signing-party-1.1.10/debian/changelog
signing-party-1.1.10/debian/changelog
--- signing-party-1.1.10/debian/changelog 2014-10-11 23:09:24.000000000
+0200
+++ signing-party-1.1.10/debian/changelog 2014-11-07 23:49:54.000000000
+0100
@@ -1,3 +1,13 @@
+signing-party (1.1.10-2) unstable; urgency=medium
+
+ [ Guilhem Moulin ]
+ * caff:
+ + Fix RCF 2822 violation: Never localize the "Date" header, regarless of
+ the LC_ALL, LC_TIME and LANG in use. Regression introduced in r698.
+ (Closes: #767371)
+
+ -- Guilhem Moulin <guil...@guilhem.org> Fri, 07 Nov 2014 21:35:13 +0100
+
signing-party (1.1.10-1) unstable; urgency=low
* debian.compat:
diff -Nru signing-party-1.1.10/debian/patches/bug767371.diff
signing-party-1.1.10/debian/patches/bug767371.diff
--- signing-party-1.1.10/debian/patches/bug767371.diff 1970-01-01
01:00:00.000000000 +0100
+++ signing-party-1.1.10/debian/patches/bug767371.diff 2014-11-07
23:49:54.000000000 +0100
@@ -0,0 +1,41 @@
+diff --git a/caff/caff b/caff/caff
+index 696c0c1..ae4bffd 100755
+--- a/caff/caff
++++ b/caff/caff
+@@ -383,7 +383,7 @@ use Fcntl;
+ use IO::Select;
+ use Getopt::Long;
+ use GnuPG::Interface;
+-use POSIX qw{strftime};
++use POSIX qw{strftime setlocale};
+
+ my %CONFIG;
+ my $REVISION = '$Rev$';
+@@ -908,7 +908,7 @@ sub create_mail($$$@) {
+ };
+
+ $message_entity->head->add("From", Encode::encode('MIME-Q',
$CONFIG{'owner'}).' <'.$CONFIG{'email'}.'>');
+- $message_entity->head->add("Date", strftime("%a, %e %b %Y %H:%M:%S %z",
localtime));
++ $message_entity->head->add("Date", strfCtime("%a, %e %b %Y %H:%M:%S
%z", localtime));
+ $message_entity->head->add("Subject", "Your signed PGP key 0x$key_id");
+ $message_entity->head->add("To", email_to_ascii($address));
+ $message_entity->head->add("Sender", Encode::encode('MIME-Q',
$CONFIG{'owner'}).' <'.$CONFIG{'email'}.'>');
+@@ -1175,6 +1175,18 @@ sub import_keys_to_sign() {
+ return 0;
+ }
+
++##
++# A non-localized version of POSIX::strftime.
++#
++sub strfCtime($@) {
++ my $lc_time = setlocale(POSIX::LC_TIME);
++ setlocale(POSIX::LC_TIME, 'C');
++ my $str = strftime(@_);
++ setlocale(POSIX::LC_TIME, $lc_time);
++ return $str;
++}
++
++
+ ###################
+ # argument handling
+ ###################
signature.asc
Description: Digital signature
