Control: tag -1 patch

On Wed, Nov 05, 2014 at 09:52:40PM +0100, Karsten Merker wrote:

> [Failing ethernet PHY detection in d-i on the BananaPi]

> Further experiments show that increasing the "startup-delay-us"
> value in the regulator definition seems to solve the issue.  I'll
> do some further experiments to determine a value that is long
> enough for a reliable detection without being unnecessary long
> and discuss the issue with the upstream author.

A patch to solve the issue has been accepted upstream (see
https://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/301727.html).
Attached is a backport of this patch for inclusion into the
upcoming linux 3.16.7-3 package.

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.
Index: debian/patches/features/arm/dts-sunxi-Banana-Pi-increase-startup-delay-for-the-GMAC-PHY-regulator.patch
===================================================================
--- debian/patches/features/arm/dts-sunxi-Banana-Pi-increase-startup-delay-for-the-GMAC-PHY-regulator.patch	(Revision 0)
+++ debian/patches/features/arm/dts-sunxi-Banana-Pi-increase-startup-delay-for-the-GMAC-PHY-regulator.patch	(Arbeitskopie)
@@ -0,0 +1,35 @@
+From f82f99afaa65fd28d0f8409c50e8fcc65ee5e15b Mon Sep 17 00:00:00 2001
+From: Karsten Merker <mer...@debian.org>
+Date: Wed, 12 Nov 2014 00:01:46 +0100
+Subject: ARM: dts: sunxi: Banana Pi: increase startup-delay for the GMAC PHY  regulator
+Origin: https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.19&id=f82f99afaa65fd28d0f8409c50e8fcc65ee5e15b
+
+On the LeMaker Banana Pi, probing the external ethernet PHY connected
+to the SoC's internal GMAC module sometimes fails. The PHY power
+supply is handled via a GPIO-controlled regulator, and the existing
+regulator startup-delay of 50000us is too short to make sure that the
+PHY is always fully powered up when it is queried by phylib. Tests
+have shown that to provide a reliable PHY detection, the startup-delay
+has to be increased to at least 60000us. To have a certain safety margin
+and to cater for manufacturing variations between different boards,
+the delay gets set to 100000us as discussed on the linux-arm-kernel
+mailinglist.
+
+Signed-off-by: Karsten Merker <mer...@debian.org>
+Acked-by: Hans de Goede <hdego...@redhat.com>
+Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
+
+diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
+index 3de847d..1cf1214 100644
+--- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
++++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
+@@ -207,7 +207,7 @@
+ 		regulator-name = "gmac-3v3";
+ 		regulator-min-microvolt = <3300000>;
+ 		regulator-max-microvolt = <3300000>;
+-		startup-delay-us = <50000>;
++		startup-delay-us = <100000>;
+ 		enable-active-high;
+ 		gpio = <&pio 7 23 0>;
+ 	};
+
Index: debian/patches/series
===================================================================
--- debian/patches/series	(Revision 22061)
+++ debian/patches/series	(Arbeitskopie)
@@ -113,6 +113,7 @@
 features/arm/dts-sun7i-Add-spi0_pins_a-pinctrl-setting.patch
 features/arm/dts-sun7i-Add-uart3_pins_b-pinctrl-setting.patch
 features/arm/dts-sun7i-Add-Banana-Pi-board.patch
+features/arm/dts-sunxi-Banana-Pi-increase-startup-delay-for-the-GMAC-PHY-regulator.patch
 features/arm/dts-sun7i-Add-support-for-Olimex-A20-OLinuXino-LIME.patch
 features/arm64/drivers-net-Add-APM-X-Gene-SoC-ethernet-driver-suppo.patch
 features/arm64/drivers-net-NET_XGENE-should-depend-on-HAS_DMA.patch

Reply via email to