Package: xvnc4viewer
Version: 4.1.1+X4.3.0-37.2
Severity: normal
Tags: patch

Hi,

it is not possible to launch xvnc4viewer with an URI like vnc://example.com:1.
Thus making it impossible to launch xvnc4viewer via an URI from the browser
(e.g. iceweasel). Please support URIs starting with vnc:// as server name. A
patch for that is attached. Do you mind me doing a NMU for that?

PS: The packaging is in a quite outdated state. I offer my (one-time) help to
update the packaging to use the latest technology (debhelper 9 with dh, 3.0
(quilt) source format). Are you interested?

-- 
Benjamin Drung
System Developer

ProfitBricks GmbH - The IaaS-Company
Greifswalder Str. 207
D - 10405 Berlin

Mail: benjamin.dr...@profitbricks.com
Fax:  +49 30 577 008 598
URL:  http://www.profitbricks.com

Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B.
Geschäftsführer: Andreas Gauger, Achim Weiss.
diff -u vnc4-4.1.1+X4.3.0/debian/changelog vnc4-4.1.1+X4.3.0/debian/changelog
--- vnc4-4.1.1+X4.3.0/debian/changelog
+++ vnc4-4.1.1+X4.3.0/debian/changelog
@@ -1,3 +1,10 @@
+vnc4 (4.1.1+X4.3.0-37.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Strip vnc:// prefix from server name to support URIs
+
+ -- Benjamin Drung <benjamin.dr...@profitbricks.com>  Mon, 17 Nov 2014 11:47:55 +0100
+
 vnc4 (4.1.1+X4.3.0-37.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -u vnc4-4.1.1+X4.3.0/unix/vncviewer/vncviewer.cxx vnc4-4.1.1+X4.3.0/unix/vncviewer/vncviewer.cxx
--- vnc4-4.1.1+X4.3.0/unix/vncviewer/vncviewer.cxx
+++ vnc4-4.1.1+X4.3.0/unix/vncviewer/vncviewer.cxx
@@ -264,6 +264,10 @@
     }
 
     vncServerName = argv[i];
+    // Strip vnc:// prefix from server name
+    if (strncmp(vncServerName, "vnc://", 6) == 0) {
+      vncServerName = &vncServerName[6];
+    }
   }
 
   // Create .vnc in the user's home directory if it doesn't already exist
only in patch2:
unchanged:
--- vnc4-4.1.1+X4.3.0.orig/debian/patches/vnc-uri.patch
+++ vnc4-4.1.1+X4.3.0/debian/patches/vnc-uri.patch
@@ -0,0 +1,18 @@
+Description: Strip vnc:// prefix from server name to support URIs
+Author: Benjamin Drung <benjamin.dr...@profitbricks.com>
+
+--- a/unix/vncviewer/vncviewer.cxx
++++ b/unix/vncviewer/vncviewer.cxx
+@@ -263,7 +263,11 @@
+       usage();
+     }
+ 
+     vncServerName = argv[i];
++    // Strip vnc:// prefix from server name
++    if (strncmp(vncServerName, "vnc://", 6) == 0) {
++      vncServerName = &vncServerName[6];
++    }
+   }
+ 
+   // Create .vnc in the user's home directory if it doesn't already exist
+
Description: Strip vnc:// prefix from server name to support URIs
Author: Benjamin Drung <benjamin.dr...@profitbricks.com>

--- a/unix/vncviewer/vncviewer.cxx
+++ b/unix/vncviewer/vncviewer.cxx
@@ -263,7 +263,11 @@
       usage();
     }
 
     vncServerName = argv[i];
+    // Strip vnc:// prefix from server name
+    if (strncmp(vncServerName, "vnc://", 6) == 0) {
+      vncServerName = &vncServerName[6];
+    }
   }
 
   // Create .vnc in the user's home directory if it doesn't already exist

Reply via email to