On Sun, Nov 09, 2014 at 09:44:38PM -0300, Felipe Sateler wrote: > On Sun, Nov 9, 2014 at 3:33 PM, Roger Leigh <[email protected]> wrote: > > On Sat, Oct 11, 2014 at 12:24:38AM -0300, Felipe Sateler wrote: > >> Package: schroot > >> Version: 1.6.10-1+b1 > >> Severity: wishlist > >> Tags: patch > >> > >> For systems without an apt proxy the local apt cache can be very useful > >> to avoid downloading stuff multiple times. Thus I created a small > >> script (attached) to copy the local apt cache contents into the chroot, > >> and then copy them back to the host on stop. pbuilder does this as well. > >> > >> This probably shouldn't be enabled by default. So perhaps this could be > >> shipped as a contrib script, or another variable added to > >> /etc/default/schroot (I can update the script if required). > > > > I think this is perfect for a contrib script; thanks for sending it. > > :) > > > > > One thing which might need correction: when it copies the files back > > on setup-stop, it's not checking for glob failure before doing the > > copy (which you do for setup-start). Would it be possible to add this > > additional check? > > Yes, indeed this causes problems when the cache is empty (for example > after a sbuild-update -c). Attached is a version that only copies > files when they exist.
Great, thanks. Would it be OK for me to add a GPL3 copyright header to match the rest of the project? Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
