On Fri, 28 Nov 2014 14:50:22 -0200 Antonio Terceiro <terce...@debian.org> wrote:
> Now sending to the correct bug ...
>
> Hey Daniel,
>
> Just a friendly ping to say that the patch to templates/lxc-debian.in
> that makes systemd containers work properly was aready merged upstream.
>
> https://github.com/lxc/lxc/commit/a9bf60bab547013a9873a3fb9efe61155e8694b8
>
> According to feedback in the upstream mailing list, the template itself > will now add the necessary configuration bits (autodev, kmsg) when the
> rootfs has systemd as PID 1, so you could probably drop
> debian/patches/0012-lxc-debian-systemd.patch (I think we don't want
> those config entries for non-systemd containers) ...

While the autodev option is negative because it means we do not get unpriveleged containers, there is a different common config for debian-userns anyway so it does not matter.

The presence of the kmsg option is fairly asthetic, no real harm having it there.

I think it would be best to keep both of those options so that if someone creates a Wheezy container (i.e. with sysvinit) then upgrades the container to Jessie it mostly works. You just do not get gettys or clean shutdown, but that is not critical because you can use `lxc-attach -n container` to resolve those issues.

And with my changes to your patch, we actually do get clean shutdown so the gettys are the only issue left (unless we reverse the 0012-lxc-debian-systemd patch, in which case we could have journald using 100% CPU and/or systemd's /sbin/init getting mad about /dev not being exactly what was expected).

So please keep that patch.

Thank you,
--
Cameron Norman

Reply via email to