Package: gitpkg Version: 0.26 Severity: normal Tags: patch Hi,
the patches generated by quilt-patches-deb-export-hook contain a signature. The default signature contains the git version number. Therefore, each time a different git version is used, the signature in all patches differs and causes unrelated noise in the debdiff. I don't know if there is a real use for the signature, so I'd propose to just disable it during patch generation. A more advanced behaviour could be to check if the user set a non-default signature and enable it only in this case. Regards, Tino -- System Information: Debian Release: 8.0 APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12.7-05353-g11687ee (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages gitpkg depends on: ii dpkg-dev 1.17.22 ii git 1:2.1.3-1 gitpkg recommends no packages. Versions of packages gitpkg suggests: ii devscripts 2.14.11 -- no debconf information
--- ./hooks/quilt-patches-deb-export-hook.orig 2014-12-09 10:36:55.548073583 +0100 +++ ./hooks/quilt-patches-deb-export-hook 2014-12-09 10:37:13.434739486 +0100 @@ -66,14 +66,14 @@ ;; *) count=$(wc -l "$patch_dir/series" | cut -f1 -d' ') - if PATCHES="$(git --git-dir "$REPO_DIR/.git" format-patch --start-number $count -N -o "$patch_dir" "$line")"; then + if PATCHES="$(git --git-dir "$REPO_DIR/.git" format-patch --no-signature --start-number $count -N -o "$patch_dir" "$line")"; then if [ -n "$PATCHES" ]; then echo "$PATCHES" | sed -e "s,$patch_dir/,,g" -e 's, ,\n,g' >> "$patch_dir/series" else echo "Warning: no patches from $line" fi else - echo "git --git-dir '$REPO_DIR/.git' format-patch --start-number $count -N -o '$patch_dir' '$line'" + echo "git --git-dir '$REPO_DIR/.git' format-patch --no-signature --start-number $count -N -o '$patch_dir' '$line'" echo "failed." exit 1 fi
