I don't intend to sponsor this but here is a review: On Sun, Nov 30, 2014 at 7:16 AM, Iain R. Learmonth wrote:
> I am looking for a sponsor for my package "libfap6". Note that "libfap5" is > already packaged in Debian and this is a new upstream version with a new > soname. Is there any reason to have both SONAMEs as different source packages in Debian? Normally we just update the same source package and rebuild reverse dependencies. Also, usually the source package name and -dev binary package name do not contain the SONAME. Upstream seems to have done that correctly btw: http://www.pakettiradio.net/downloads/libfap/1.4/ Usually there is no reason to ship static libraries unless someone has specifically requested them. Most of the comments in debian/rules appear to be unnecessary. The libfap6 binary package should probably be in section libs. As this is a parser for data transferred over the network, you might want to try running the code with a fuzzer such as zzuf or the more intelligent fuzzer american-fuzzy-lop (not yet in Debian) and or under things like valgrind. If you don't mind interfacing with proprietary network services, Coverity offers gratis static analysis scans to free software projects. http://lcamtuf.coredump.cx/afl/ https://ftp-master.debian.org/new/afl_0.65b-1.html https://scan.coverity.com/ Automated checks: https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git $ lintian P: libfap6 source: debian-watch-may-check-gpg-signature I: libfap6: no-symbols-control-file usr/lib/x86_64-linux-gnu/libfap.so.6.0.0 $ codespell --quiet-level=3 ./THANKS:5: facilites ==> facilities ./src/fap.h:256: Lenght ==> Length ./src/fap.h:448: occured ==> occurred ./src/fap.h:463: successfull ==> successful ./src/fap.h:464: occured ==> occurred ./src/helpers.c:1489: existance ==> existence ./src/helpers2.h:119: Lenght ==> Length $ cppcheck -j1 --quiet -f . [src/helpers.c:3014]: (error) Memory leak: tmp_str [src/helpers.c:3027]: (error) Memory leak: tmp_str [src/helpers.c:3040]: (error) Memory leak: tmp_str [src/helpers.c:3053]: (error) Memory leak: tmp_str [src/helpers.c:3066]: (error) Memory leak: tmp_str [src/helpers.c:3079]: (error) Memory leak: tmp_str <some warnings and style issues with --enable=all> $ duck E: debian/control: Vcs-Git: http://anonscm.debian.org/git/collab-maint/libfap6.git: ERROR (Certainty:certain) fatal: repository 'http://anonscm.debian.org/git/collab-maint/libfap6.git/' not found E: debian/control: Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/libfap6.git: ERROR (Certainty:certain) Curl:0 HTTP:404 No error $ find -type f \( -iname '*.c' -o -iname '*.cc' -o -iname '*.cxx' -o -iname '*.cpp' -o -iname '*.h' -o -iname '*.hh' -o -iname '*.hxx' -o -iname '*.hpp' \) -exec include-what-you-use {} \; <a bunch of issues> -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
