Package: atomix Version: 2.14.0-5 Severity: normal Tags: patch User: [email protected] Usertags: origin-ubuntu vivid ubuntu-patch
Dear Maintainer, In Ubuntu, we use ld --as-needed by default in the toolchain, and you package fails to build from source with that option enabled because of the way libraries are linked. Even though Debian doesn't use ld --as-needed by default, it is a good idea to make this change so that (1) we don't have to maintain a delta and (2) you don't need to change anything in case Debian makes this default in the future. You can read more about this option here: https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries In Ubuntu, the attached patch was applied to achieve the following: * debian/patches/underlinking.diff: Restore Robie Basak's patch from 2.14.0-2ubuntu2 to build with -lm to fix an underlinking FTBFS. * Use dh-autoreconf so that the patch is applied. * Remove unnecessary -lm addition in debian/rules for LDFLAGS. Thanks for considering the patch. Logan Rosen -- System Information: Debian Release: jessie/sid APT prefers vivid-updates APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), (100, 'vivid-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru atomix-2.14.0/debian/control atomix-2.14.0/debian/control --- atomix-2.14.0/debian/control 2013-03-03 22:06:27.000000000 -0500 +++ atomix-2.14.0/debian/control 2014-12-14 03:25:27.000000000 -0500 @@ -4,8 +4,8 @@ Maintainer: Debian Games Team <[email protected]> Uploaders: Markus Koschany <[email protected]> Build-Depends: - autotools-dev, debhelper (>= 9), + dh-autoreconf, gnome-common, libglib2.0-dev, libgnome2-dev, diff -Nru atomix-2.14.0/debian/patches/series atomix-2.14.0/debian/patches/series --- atomix-2.14.0/debian/patches/series 2013-03-03 22:06:27.000000000 -0500 +++ atomix-2.14.0/debian/patches/series 2014-12-04 23:47:07.000000000 -0500 @@ -1,2 +1,3 @@ desktop.patch about.patch +underlinking.diff diff -Nru atomix-2.14.0/debian/patches/underlinking.diff atomix-2.14.0/debian/patches/underlinking.diff --- atomix-2.14.0/debian/patches/underlinking.diff 1969-12-31 19:00:00.000000000 -0500 +++ atomix-2.14.0/debian/patches/underlinking.diff 2014-12-05 00:03:54.000000000 -0500 @@ -0,0 +1,15 @@ +Author: Robie Basak <[email protected]> +Description: Build with -lm to fix FTBFS +Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697371 +Last-Update: 2013-04-05 + +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -26,6 +26,7 @@ + + atomix_LDADD = \ + libatomix.a \ ++ -lm \ + $(ATOMIX_LIBS) + + noinst_LIBRARIES = libatomix.a diff -Nru atomix-2.14.0/debian/rules atomix-2.14.0/debian/rules --- atomix-2.14.0/debian/rules 2013-06-22 14:28:41.000000000 -0400 +++ atomix-2.14.0/debian/rules 2014-12-05 00:05:40.000000000 -0500 @@ -1,9 +1,9 @@ #!/usr/bin/make -f -export DEB_LDFLAGS_MAINT_APPEND = -lm -Wl,--as-needed +export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed export DEB_BUILD_MAINT_OPTIONS = hardening=+all %: - dh $@ --parallel --with autotools_dev + dh $@ --parallel --with autoreconf override_dh_auto_configure: dh_auto_configure -- \
