Hi,
On 28/12/14 14:22, "Guido Günther" <[email protected]> wrote:
>On Tue, Dec 16, 2014 at 10:09:15AM +0200, Markus Lehtonen wrote:
>> On Fri, 2014-12-05 at 15:50 +0100, Guido Günther wrote:
>> > Hi Markus,
>> > On Tue, Dec 02, 2014 at 04:47:58PM +0200, Markus Lehtonen wrote:
>> > > Hello,
>> > >
>> > > On Fri, 2014-11-28 at 14:55 +0100, Guido Günther wrote:
>> > > > On Fri, Nov 28, 2014 at 12:11:01PM +0200, Markus Lehtonen wrote:
>> > > > [..snip..]
>> > > > > If you're willing to wait for few days I could look into this
>>and provide
>> > > > > a patchset with minimal pq-rpm implementation (i.e. all the new
>>cmdline
>> > > > > options, even configurable branch names, removed). What I'd
>>like to have
>> > > > > there are the unit tests.
>> > > >
>> > > > That would be awesome! I'd be great to have a second tool merged.
>> > >
>> > > The attached series implements an initial version of the pq-rpm
>>tool.
>> > > The first four patches (0001-0004) are required to make the actual
>> > > pq-rpm tool to work correctly. The next four patches (0005-0008) are
>> > > requirements for the unit tests. The last patch finally implements
>> > > gbp-pq-rpm tool itself.
>> > >
>> > > This series (plus some additional features) is also available in
>> > > feature/pq-rpm branch in my Github repository:
>> > > git clone git://github.com/marquiz/git-buildpackage-rpm.git -b
>> > > feature/pq-rpm
>> >
>> > I had a look at this branch an it looks great. I'd feel more
>> > comfortable if we'd had a unit test for dump_tree with recursive
>> > though (af39e32692ebedb4316b28851e10f737bf176105) - can you add that,
>> > I can pull in the rest then.
>>
>> You can find a patch with updated unit tests attached. I also updated
>> and rebased my feature/pq-rpm branch in Github.
>
>I've pulled in the patches up to
>
>but the tests fail with:
>
>======================================================================
>ERROR: test suite for <class 'tests.component.rpm.test_pq_rpm.TestPqRpm'>
>----------------------------------------------------------------------
>Traceback (most recent call last):
> File "/usr/lib/python2.7/dist-packages/nose/suite.py", line 209, in run
> self.setUp()
> File "/usr/lib/python2.7/dist-packages/nose/suite.py", line 292, in
>setUp
> self.setupContext(ancestor)
> File "/usr/lib/python2.7/dist-packages/nose/suite.py", line 315, in
>setupContext
> try_run(context, names)
> File "/usr/lib/python2.7/dist-packages/nose/util.py", line 470, in
>try_run
> return func()
> File
>"/var/scratch/src/git-buildpackage/git-buildpackage/tests/component/rpm/__
>init__.py", line 93, in setup_class
> repo.create_branch(branch, rev)
> File
>"/var/scratch/src/git-buildpackage/git-buildpackage/gbp/git/repository.py"
>, line 311, in create_branch
> self._git_command("branch", args.args)
> File
>"/var/scratch/src/git-buildpackage/git-buildpackage/gbp/git/repository.py"
>, line 207, in _git_command
> raise GitRepositoryError("Error running git %s: %s" % (command,
>stderr))
>GitRepositoryError: Error running git branch: fatal: Not a valid branch
>point: 'b82fd1a61db4221263b2c110f60c6d07cb0203df'.
>
>I assume that the subproject commit of tests/component/rpm/data in
>63a5a1aedb5e14e6d32a942b2a4c6de42b14a8f2 is incorrect?
The pq-rpm unit tests utilize many refs (refs/gbp-test*/*) from the
submodule repository. The problem probably is that my testdata repo was in
inconsistent state at the time you ran git-submodule update and some refs
in your local copy are out-of-date. Re-running git-submodule update now
won't fetch them as the submodule HEAD is already up-to-date. Try doing
"git submodule foreach git fetch origin" and re-running the tests. I
didn't want to clone/fetch from the remote repo inside the tests in order
to not depend on network connection.
Thanks,
Markus
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
