Package: sbuild
Severity: normal
Tags: patch
Hi,
firstly, libsbuild-perl currently has a hard dependency on "exim |
mail-transport-agent" even though it runs just fine without a sendmail
binary being installed. Looking through the code, none of the calls to
functions that end up invoking sendmail (send_mail, ll_send_mail and
send_build_log) check for successful completion. Thus, sbuild runs fine
without "exim | mail-transport-agent", just with reduced functionality.
Additionally, sending reports by email is hardly useful when not running
as a buildd. Furthermore, mail transport agents will start a service in
the background which has to be manually disabled. It would be great if
sbuild could be installed without having to either run a new service in
the background or having to disable it (which one might forget). It
would thus be great if this Depends could be made a Recommends.
Secondly, libsbuild-perl currently has a hard dependency on "schroot"
even though it runs just fine without schroot in sudo mode. It would
thus be great if this Depends could be made a Recommends because
clearly, sbuild works without it.
Patches for both issues are attached.
cheers, josch
>From a4651e439b299167c8ebb953f036824f1bae5bec Mon Sep 17 00:00:00 2001
From: josch <j.scha...@email.de>
Date: Wed, 31 Dec 2014 15:47:42 +0100
Subject: [PATCH 1/2] libsbuild-perl: demote Depends: exim |
mail-transport-agend to Recommends
---
debian/changelog | 3 +++
debian/control | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 46cca0d..06d9664 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ sbuild (0.65.1-1) UNRELEASED; urgency=medium
are present in the arch list (Closes: #771235). Thanks to
Lennart Sorensen for this patch.
+ [ Johannes Schauer ]
+ * libsbuild-perl: demote Depends: exim | mail-transport-agend to Recommends
+
-- Roger Leigh <rle...@debian.org> Sun, 30 Nov 2014 22:44:47 +0000
sbuild (0.65.0-1) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index 6146347..dba1363 100644
--- a/debian/control
+++ b/debian/control
@@ -28,7 +28,6 @@ Depends: adduser,
dctrl-tools,
devscripts (>= 2.10.26),
dpkg-dev,
- exim4 | mail-transport-agent,
libdpkg-perl (>= 1.17.2),
libexception-class-perl,
libfilesys-df-perl,
@@ -38,6 +37,8 @@ Depends: adduser,
schroot (>= 1.4.22),
${misc:Depends},
${perl:Depends}
+Recommends:
+ exim4 | mail-transport-agent
Replaces: sbuild (<= 0.58.4-1)
Description: Tool for building Debian binary packages from Debian sources
The sbuild suite of programs (wanna-build, buildd and sbuild) are
--
2.0.1
>From 94f14ebc8ab0bd90bdf4b36476ef164837be9937 Mon Sep 17 00:00:00 2001
From: josch <j.scha...@email.de>
Date: Wed, 31 Dec 2014 16:11:11 +0100
Subject: [PATCH 2/2] libsbuild-perl: demote Depends: schroot to Recommends
---
debian/changelog | 1 +
debian/control | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 06d9664..27aeccb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,7 @@ sbuild (0.65.1-1) UNRELEASED; urgency=medium
[ Johannes Schauer ]
* libsbuild-perl: demote Depends: exim | mail-transport-agend to Recommends
+ * libsbuild-perl: demote Depends: schroot to Recommends
-- Roger Leigh <rle...@debian.org> Sun, 30 Nov 2014 22:44:47 +0000
diff --git a/debian/control b/debian/control
index dba1363..84a81e4 100644
--- a/debian/control
+++ b/debian/control
@@ -34,10 +34,10 @@ Depends: adduser,
libio-zlib-perl,
libmime-lite-perl,
perl-modules,
- schroot (>= 1.4.22),
${misc:Depends},
${perl:Depends}
Recommends:
+ schroot (>= 1.4.22),
exim4 | mail-transport-agent
Replaces: sbuild (<= 0.58.4-1)
Description: Tool for building Debian binary packages from Debian sources
--
2.0.1
