Package: gitolite3 Severity: wishlist
Hi. I've had some discussion with upstream[0], about whether a better shell than /bin/bash can be used. Obivously /bin/false isn’t possible as this also makes any command="..." execution impossible. But still, two better choices exist IMHO: a) /bin/sh (which is dash in Debian) It's smaller, faster, less bloated (and has probably less security issues). or even better: b) an upcoming shell-mode feature, that Sitaram was so nice to implement based on my suggestion: https://github.com/sitaramc/gitolite/commit/9cd1e373e197e9191c6ed9b85da8a2b411e65f2f While he marks it as “Experts only; no support, no docs”, I wouldn't see any chances that this could affect the usage of gitolite a lot, if at all (actually it save a few forks and makes things faster). So if the Debian maintainers agree, than Debian could use this shell-mode as the default, or at least ask users via debconf whether they wish to use it. The benefits (next to a small, probably unmeasurable performance gain ;) ) is the bigger security, i.e. when someone somehow accidentally adds a ssh key manually to ~git/.ssh/authorized_keys, with out the restricting command="...." that gitolite adds, than such user would get full shell access (regardless of bash or dash) and as such also full access to ALL repos. Cheers, Chris. [0] https://groups.google.com/d/msg/gitolite/eLTiK8hvijo/9dKI8YfTSecJ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
