control: tags -1 wontfix control: severity -1 normal Am 18.02.2015 um 01:25 schrieb Christian Seiler: > Am 18.02.2015 um 00:38 schrieb Ansgar Burchardt: >>> I've implemented both of these and attached a modified version of >>> the patch. Do you have any objections? If not, I'll ask for pre- >>> approval by the release team. >> >> The load_sysv function also has a heuristic to guess whether the init >> script support the "release" action or not: >> >> /* Try to figure out whether this init script >> supports >> * the reload operation. This heuristic looks for >> * "Usage" lines which include the reload option. */ >> >> As far as I can see this will no longer work with the proposed changes >> when an override file is present: load_sysv will only process the >> override file and never see the "usage" line used in the heuristic. > > Oh, nice catch, thanks! > > I've changed the logic slightly and tested it in all four possible > combinations (w/ or w/o reload support, w/ or w/o override), it now > works as expected. I also looked at the function to see if there > were some other surprises in there, but the the rest just parses > headers. > > I've attached an updated patch. Any objections to that?
Thanks a lot for the patch and raising this with the release team. I see that you already got some review from Ansgar. Removing the wontfix tag, given the additional information we have now, i.e. we currently don't have a proper way to override orderings/dependencies via drop-ins, and the feature, while not really used in the Debian archive, it seems to be somewhat more widely used locally by system admins. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
