Hi Stefan, Am 17.03.2015 um 03:51 schrieb Stefan Lippers-Hollmann: > Hi > > On 2015-03-16, Michael Biebl wrote: >> Package: wpasupplicant >> Version: 2.3-1 >> Severity: important >> >> Hi, >> >> please add a Before=network.target dependency >> to the [Unit] section of wpa_supplicant.service. This ensures, that >> wpa_supplicant is stopped on shutdown *after* remote mount points have >> been unmounted. See also the discussion at [1]. > > Thanks a lot for reporting this, even more for hinting at the solution :) > > Looking at it more thoroughly, I think "After=syslog.target" might be > needed as well, given that (by default) wpa_supplicant uses the syslog > facilities for logging purposes. Therefore I'd suggest this patch > instead:
After=syslog.target is not necessary, it will actually generate a lintian warning, since using that is deprecated. sysloggers are socket activated nowadays, so don't need an explicit dependency. > ### snip ### > wpasupplicant: fix systemd unit dependencies > > wpasupplicant needs to be started before the network target > (Closes: 780552). > > Debian bug: https://bugs.debian.org/780552 > Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769186#41 > systemd upstream bug: https://bugs.freedesktop.org/show_bug.cgi?id=86707#c3 > > Signed-off-by: Stefan Lippers-Hollmann <[email protected]> > > --- a/wpa_supplicant/systemd/wpa_supplicant.service.in > +++ b/wpa_supplicant/systemd/wpa_supplicant.service.in > @@ -1,5 +1,7 @@ > [Unit] > Description=WPA supplicant > +Before=network.target > +After=syslog.target > > [Service] > Type=dbus > ### snip ### > > Do you agree with this evaluation? See above. See also http://www.freedesktop.org/wiki/Software/systemd/syslog/ "we do no longer recommend people to order their units after syslog.target" > Given the current stage of the freeze[1], would you like to get this > uploaded for jessie? In that case I'll coordinate with release and d-i > teams after the upload to unstable, pending release and udeb unblock, it > should migrate without problems. Good question. I think the combination of wireless + remote FS (like NFS) is not that common that we must need to get this into jessie. If you plan another upload though, I would probably squeeze that one in since it has pretty low regression potential. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
