Hello Daniel, On 02/02/2015 10:22 PM, Daniel Stender wrote: > I'm looking for a sponsor for my package of Manuel 1.8.0 [1].
I cannot yet act as a sponsor just yet, as I'm still in the NM process. However, I can provide some immediate feedback, now. Once I become a DD, I'm happy to sponsor this package. > It builds those binary packages: > python-manuel - Python library for testable documents and documented tests > python3-manuel - Python3 library for testable documents and documented tests > > Mentors upload: > http://mentors.debian.net/package/manuel > http://mentors.debian.net/debian/pool/main/m/manuel/manuel_1.8.0-1.dsc > > Buildlog: > http://www.danielstender.com/buildlogs/manuel_1.8.0-1_amd64-20150202-2204.build > > I've made everything ready for a injection into the DPMT repository > (SVN fields and Uploaders present). Cool, thanks. The upstream tarball is okay, the license appropriate for distribution by Debian. And copyright information is properly tracked in debian/copyright. debian/changelog: the file I got from mentors.d.o has stable-proposed-updates as a target. That's very unlikely to happen. Please change this to unstable (or leave it at UNRELEASED as in the subversion repository and your sponsor will switch it to unstable). debian/control: As per the advice of my AM, you don't need the X-Python-Version: >= 2.6 line, as even oldstable provides python-2.6. Same applies to the B-D on python-all (>= 2.6.6-3~). Please remove those in the context of an upload to unstable (or experimental). debian/rules: handling of nodocs looks good and works for me. Docs get installed and registered with doc-base. However, please consider bundling the documentation in a separate -doc package, as it's relatively big compared to the python files. And it's good to avoid the duplication, there. debian/watch: looks fine and works for me. debian/source/*, debian/compat: just a very minor nitpick: I miss a trailing newline on these files. Not that this breaks anything, but I think it's common practice. Thank you for your contribution. Regads Markus Wanner
signature.asc
Description: OpenPGP digital signature
