Control: tags -1 +pending
On 2015-04-17 02:17:05, Matthijs Kooijman wrote:
> Hi Antoine,
>
>> What do you have in DAEMON_ARGS then?
> DAEMON_ARGS="--fork --config /data/applications/grobbebol/grobbebol.cfg"
>
>> One thing that strikes me as a possibility is that I probably don't use
>> the init.d script at all here. I am running willie in a Jessie system
>> running systemd as PID 1. Furthermore, i use a slight modification of
>> the startup script:
> That would certainly explain it. Looking at the service file, it doesn't
> use willie --quit at all, instead relying on systemd to keep track of
> the pid and send signals.
That is my assumption as well - in fact it doesn't even make willie
--fork.
> I've attached the patch I'm running with now. This makes stopping and
> restarting work most of the time.
Awesome, I factored it in the git repo, it will be part of the next
upload.
> Still unsolved is that if stopping takes a long time, or never
> completes, --kill is never called and the subsequent start happens
> immediately and fails.
Why is that? is it because the return value of --quit is incorrect?
should a bug report be filed there?
I see that the RETVAL is taken from the output of the `rm`, maybe that's
not right...
> Fixing the latter would require --quit to actually wait (with a
> timeout) for willie to quit, or it would require redoing the pidfile
> logic and the wait inside the initscript, I guess. I don't have time
> to implement either, unfortunately.
Understood... I guess it's a good enough patch for now, if you have any
other contributions, they would be very welcome!
Thanks!
A.
--
The greatest tragedy in mankind's entire history may be the hijacking of
morality by religion.
- Arthur C. Clarke
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
