On Wed, Feb 11, 2015 at 09:40:21AM +0000, Barak A. Pearlmutter wrote:

> +Vcs-Git: git://github.com/barak/usbview.git
> +Vcs-Browser: https://github.com/barak/usbview

Hrm...

> From 5a39e69f94f06d54db67f7a4b122a14630794960 Mon Sep 17 00:00:00 2001
> From: "Barak A. Pearlmutter" <[email protected]>
> Date: Thu, 5 Feb 2015 16:14:31 +0000
> Subject: [PATCH 3/5] git ignore debian debris

Not applying this since the package isn't maintained in git.

> Invoke command as root in menu entries.
> Satisfy desktop-file-validate.
> Silence lintian tag su-wrapper-not-su-to-root.
> Silence lintian tag desktop-entry-lacks-keywords-entry.
> Install and enable upstream 64x64 icon, in original and 32x32 resolutions.
> ---
>  debian/.gitignore      |  1 +
>  debian/clean           |  2 ++
>  debian/control         |  1 +
>  debian/rules           | 11 +++++++++++
>  debian/usbview.desktop |  8 +++++---
>  debian/usbview.install |  3 +++
>  debian/usbview.menu    |  4 ++--
>  7 files changed, 25 insertions(+), 5 deletions(-)
>  create mode 100644 debian/clean
>  create mode 100644 debian/usbview.install

I've applied most of your other patches but you're not updating the
changelog for anything which is a bit painful, please remember to do
that.  It's also much easier if you can do one change per patch (that is
both easier to review and means that a problem with one part of the set
needn't get in the way of applying other bits) and write the changelogs
to describe the change that's being made rather than the expected output
for some tool (silencing a lintian warning could be done in many ways
for example).

I also had to fix build failures due to missing build dependencies for
part of imagemagick and reformat the build deps to a more normal style.

Attachment: signature.asc
Description: Digital signature

Reply via email to