Hello, Lucas' patch is obviously correct, but there are several other errors in the test. Attached patch fixes them all, and crash's "live" autopkgtest now succeeds under Ubuntu too.
Thanks, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -u crash-7.0.8/debian/changelog crash-7.0.8/debian/changelog --- crash-7.0.8/debian/changelog +++ crash-7.0.8/debian/changelog @@ -1,3 +1,18 @@ +crash (7.0.8-2) UNRELEASED; urgency=medium + + * Fix autopkgtest: + - Drop sudo calls; they potentially hang forever asking for a password or + might get denied, destroy the environment, and are not necessary as the + test already has "needs-root". + - Fix invalid indentation of here-doc + - Suppress expected stderr output of apt-key (which causes a test failure) + - Drop "set -x", as that causes stderr output and the called commands are + already verbose enough. + - Drop -security pocket for Ubuntu's ddebs.u.c., as that does not exist. + - Closes: #756969 + + -- Martin Pitt <[email protected]> Thu, 30 Apr 2015 11:49:33 +0200 + crash (7.0.8-1) unstable; urgency=medium * Fix for the handling of 32-bit ELF xendump dumpfiles if the guest was diff -u crash-7.0.8/debian/tests/live crash-7.0.8/debian/tests/live --- crash-7.0.8/debian/tests/live +++ crash-7.0.8/debian/tests/live @@ -1,20 +1,20 @@ -#/bin/sh -x +#/bin/sh set -e echo "Adding linux-image debug symbols." if [ "$(lsb_release -is)" = "Debian" ]; then - sudo apt-get install linux-image-$(uname -r)-dbg + apt-get install linux-image-$(uname -r)-dbg elif [ "$(lsb_release -is)" = "Ubuntu" ]; then - sudo tee /etc/apt/sources.list.d/ddebs.list << EOF - deb http://ddebs.ubuntu.com/ $(lsb_release -cs) main restricted universe multiverse - deb http://ddebs.ubuntu.com/ $(lsb_release -cs)-security main restricted universe multiverse - deb http://ddebs.ubuntu.com/ $(lsb_release -cs)-updates main restricted universe multiverse - deb http://ddebs.ubuntu.com/ $(lsb_release -cs)-proposed main restricted universe multiverse - EOF - sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys ECDCAD72428D7C01 - sudo apt-get update - sudo apt-get install linux-image-$(uname -r)-dbgsym + tee /etc/apt/sources.list.d/ddebs.list << EOF +deb http://ddebs.ubuntu.com/ $(lsb_release -cs) main restricted universe multiverse +deb http://ddebs.ubuntu.com/ $(lsb_release -cs)-updates main restricted universe multiverse +deb http://ddebs.ubuntu.com/ $(lsb_release -cs)-proposed main restricted universe multiverse +EOF + # avoid stderr output + apt-key adv --keyserver keyserver.ubuntu.com --recv-keys ECDCAD72428D7C01 2>&1 + apt-get update + apt-get install linux-image-$(uname -r)-dbgsym fi echo "Testing crash on live kernel" -sudo crash -st /usr/lib/debug/boot/vmlinux-$(uname -r) +crash -st /usr/lib/debug/boot/vmlinux-$(uname -r)
signature.asc
Description: Digital signature
