On Fri, May 15, 2015 at 07:40:46PM +0200, Gudjon I. Gudjonsson wrote:
> This needs fortifying but if I uncomment the fortifying flags in the 
> debian/rules file I get the following error:
> /usr/include/wx-3.0/wx/ctrlsub.h:144: undefined reference to `non-virtual 
> thunk 
> to wxListBoxBase::IsSorted() const'
> Do you know how to solve this? I don't have a clue.

Turning off fortifying didn't seem to make a difference for me, but
switching from -O2 to -O1 did.

It would be good to get to the bottom of what's going on here, but
I suggest uploading the package built with -O1 as a workaround so we at
least have recent version of gspiceui packaged which doesn't block the
removal of wxwidgets2.8.

I've attached a patch of the changes I built with.  A quick explanation:


1.1.00 is an actual release rather than a "New svn version", and the
changelog entry date is from last July - I guess these are left over
from when you were working on this back then.


There's no need to depend on both libwxbase3.0-dev and libwxgtk3.0-dev.

And "DM-Upload-Allowed: yes" is obsolete, so there's no use in keeping
it there but commented out.

"Version" here is the version of the .desktop file format, not the
program - see:

I tweaked it to change -O2 in CXXFLAGS to -O0.

Also, there's no need to handle noopt yourself - dpkg-buildflags does
it for you:

$ dpkg-buildflags --get CFLAGS
-g -O2 -fstack-protector-strong -Wformat -Werror=format-security
$ DEB_BUILD_OPTIONS=noopt dpkg-buildflags --get CFLAGS
-g -O0 -fstack-protector-strong -Wformat -Werror=format-security

Let me know if you'd like me to sponsor an upload.  Or I can just NMU
if you're happy with the changes in the patch.

diff -ruN gspiceui-1.1.00+dfsg.orig/debian/changelog gspiceui-1.1.00+dfsg/debian/changelog
--- gspiceui-1.1.00+dfsg.orig/debian/changelog	2015-05-15 08:24:05.000000000 +1200
+++ gspiceui-1.1.00+dfsg/debian/changelog	2015-05-18 18:00:27.148118148 +1200
@@ -1,8 +1,8 @@
 gspiceui (1.1.00+dfsg-1) unstable; urgency=medium
-  * New svn version (Closes: #750743)
+  * New upstream release
   * Bump standards version to 3.9.5
-  * Change wx dependencies to version 3.0
+  * Change wx dependencies to version 3.0 (Closes: #750743)
   * Update copyright file, new download site and license changed to GPL-3
   * Add patch 01_makefile to fix errors in makefile
   * Add patch 02_fix_compilation to fix a source file
@@ -17,7 +17,7 @@
   * Add patch 05_manual_path to fix path to html manual
   * Fix project homepage in control file
- -- Gudjon I. Gudjonsson <gud...@gudjon.org>  Fri, 11 Jul 2014 08:57:18 +0000
+ -- Gudjon I. Gudjonsson <gud...@gudjon.org>  Mon, 18 May 2015 00:47:07 +0000
 gspiceui (1.0.00+dfsg-1) unstable; urgency=low
diff -ruN gspiceui-1.1.00+dfsg.orig/debian/control gspiceui-1.1.00+dfsg/debian/control
--- gspiceui-1.1.00+dfsg.orig/debian/control	2015-05-15 08:20:11.000000000 +1200
+++ gspiceui-1.1.00+dfsg/debian/control	2015-05-18 12:34:14.604991548 +1200
@@ -2,12 +2,11 @@
 Section: electronics
 Priority: optional
 Maintainer: Gudjon I. Gudjonsson <gud...@gudjon.org>
-Build-Depends: debhelper (>= 8), libwxbase3.0-dev, libwxgtk3.0-dev
+Build-Depends: debhelper (>= 8), libwxgtk3.0-dev
 Standards-Version: 3.9.5
 Homepage: http://sourceforge.net/projects/gspiceui/
 Vcs-Svn: svn://anonscm.debian.org/debian-science/packages/gspiceui/trunk/
 Vcs-Browser: http://anonscm.debian.org/viewvc/debian-science/packages/gspiceui/trunk
-#DM-Upload-Allowed: yes
 Package: gspiceui
 Architecture: any
diff -ruN gspiceui-1.1.00+dfsg.orig/debian/gspiceui.desktop gspiceui-1.1.00+dfsg/debian/gspiceui.desktop
--- gspiceui-1.1.00+dfsg.orig/debian/gspiceui.desktop	2014-07-03 10:49:34.000000000 +1200
+++ gspiceui-1.1.00+dfsg/debian/gspiceui.desktop	2015-05-18 12:35:55.181155882 +1200
@@ -1,5 +1,5 @@
 [Desktop Entry]
 GenericName=GNU Spice GUI
 Comment=Graphical frontend to Spice simulators
diff -ruN gspiceui-1.1.00+dfsg.orig/debian/rules gspiceui-1.1.00+dfsg/debian/rules
--- gspiceui-1.1.00+dfsg.orig/debian/rules	2015-05-16 05:00:28.000000000 +1200
+++ gspiceui-1.1.00+dfsg/debian/rules	2015-05-18 18:01:46.091855606 +1200
@@ -6,15 +6,11 @@
 CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
 CFLAGS:=$(shell dpkg-buildflags --get CFLAGS)
-CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS)  $(shell dpkg-buildflags --get CPPFLAGS)
+# Compile at -O1 instead of -O2 for now to work around:
+# /usr/include/wx-3.0/wx/ctrlsub.h:144: undefined reference to `non-virtual thunk to wxListBoxBase::IsSorted() const'
+CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS|sed 's/-O2//') $(CPPFLAGS)
 LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-	CFLAGS += -O2
 build: build-arch build-indep
 build-arch: build-arch-stamp

Reply via email to