Package: grml-debootstrap
Version: 0.68.1
Severity: normal
Tags: patch

Dear Maintainer,

Firstly, I was quite surprised to note that installing Debian with grml
defaults to including non-free -- is this really the default we wish to
ship in Debian?

Having discovered that, I set the following in the config file:

  COMPONENTS='main'

and found that I then got errors regarding the lack of availability of 
firmware-linux

Attached is a patch that makes the inclusion of firmware-linux conditional
on the presence of non-free in COMPONENTS.

-- System Information:
Debian Release: 8.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages grml-debootstrap depends on:
ii  debian-archive-keyring  2014.3
ii  debootstrap             1.0.67
ii  gawk                    1:4.1.1+dfsg-1

Versions of packages grml-debootstrap recommends:
ii  dialog      1.2-20140911-1
ii  kpartx      0.5.0-6
ii  mksh        50d-5
ii  parted      3.2-7
ii  qemu-utils  1:2.1+dfsg-12

grml-debootstrap suggests no packages.


______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________
diff --git a/chroot-script b/chroot-script
index 1a74aef..95bd025 100755
--- a/chroot-script
+++ b/chroot-script
@@ -343,7 +343,11 @@ kernel() {
   KVER=$(get_kernel_version)
   if [ -n "$KVER" ] ; then
      # note: install busybox to be able to debug initramfs
-     KERNELPACKAGES="linux-image-$KVER linux-headers-$KVER busybox firmware-linux-free firmware-linux"
+     KERNELPACKAGES="linux-image-$KVER linux-headers-$KVER busybox firmware-linux-free"
+     # only add firmware-linux if we have non-free as a component
+     if expr "$COMPONENTS" : '.*non-free' >/dev/null ; then
+       KERNELPACKAGES="$KERNELPACKAGES firmware-linux"
+     fi
      DEBIAN_FRONTEND=$DEBIAN_FRONTEND $APTINSTALL $KERNELPACKAGES
   else
      echo "Warning: Could not find a kernel for your system. Your system won't be able to boot itself!"

Reply via email to