Control: tags 786878 wishlist Hi, On Tue, May 26, 2015 at 11:28:21AM +0000, lumin wrote: > Package: debmake > Version: 4.2.0-1 > > Hi, > > When I'm making upstream tarball with debmake -t, > (In an already packaged source tree) > I noticed that debmake excluded debian/ directory, > but not .pc directory. See the bottom script.
The upstream should not have .pc directory :-) Hmmm... I did not think about "not removing .pc directory". I am using git and I have "git-zap" essentially do: --- git reset --hard HEAD git clean -d -f -x --- This clean up most of junks. (Yes, I have some sanity check around this to prevent me wiping out /etc etc.) But let me think a bit on this later. > I tried a quick hack on file tar.py but failed. > > * the gnu tar doesn't work with multiple --exclude arg > i.e. tar --exclude=dirA --exclude=dirB You may send a wishlist bug with patch to the tar package on this :-) > * the gnu tar doesn't work with another style of multiple exclude > i.e. tar --exclude=dirA,dirB No Bash pattern... Tar is stupid. > * in order to exclude multiple files/dirs, tar -X may help > but we can't hardcode, here for example, strings like "cv-0.6" > into a list file tar-exclude.list for tar -X Yah... too much. > Then I gave up to try. However I think this problem can be solved > in one way of followwing > > * rsync source tree to dest, then rm [-r] files/dirs we don't > want for a upstream source. > * rsync with multiple --exclude options. > * [...] > > Another problem is, should we dquilt pop -a before making an > upstream tarball? I did not find "quilt" in tar.py. > > I submit this bug because, IMHO it would be better if debmake -t > can make upstream tarballs in an already packaged source tree, > avoiding user to pop patches, exclude dirs/cvs, and then tar zcvf > by hand. namely it would be more convenient". "debmake -t" is expected to run from ithe upstream VCS source tree possibly with debian/* directory but clean with .pc and patch unapplied. I did not assume to do this from the source tree created by dpkg-soutrce -s foo-*.dsc This may have .pc and patch may be applied. But in this case, you already have upstream tar. Why you need "debmake -t". So I think best thing is warn user for .pc directory and error exit. I may need to explain this in the manual. > If this is a bad idea, IMO debmake should at least warn > user (human) the existence of .pc dir, saying > "this is not the original source tree". Yes Osamu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
