On 05/27/2015 11:26 AM, Jérémy Bobbio wrote:
>> --- python3.5-3.5.0~b1/debian/rules  2015-05-26 02:07:36.000000000 +0200
>> +++ python3.5-3.5.0~b1/debian/rules  2015-05-27 09:28:58.000000000 +0200
>> @@ -23,6 +23,17 @@
>>  PKGSOURCE  := $(call vafilt,$(CHANGELOG_VARS),Source)
>>  PKGVERSION := $(call vafilt,$(CHANGELOG_VARS),Version)
>>  
>> +LAST_CHANGE = $(shell dpkg-parsechangelog -S Date)
>> +
>> +BUILD_DATE := $(shell LC_ALL=C date -u +'"%H:%M:%S"' -d "$(LAST_CHANGE)")
>> +BUILD_TIME := $(shell LC_ALL=C date -u +'"%b %e %Y"' -d "$(LAST_CHANGE)")
> 
> These two are reversed. It should be:
> 
> BUILD_DATE := $(shell LC_ALL=C date -u +'"%b %e %Y"' -d "$(LAST_CHANGE)")
> BUILD_TIME := $(shell LC_ALL=C date -u +'"%H:%M:%S"' -d "$(LAST_CHANGE)")
> 
> Sorry about the noise.

the patch is incomplete, not creating/removing the datetime.h file. your patch
is wrong, because it adds this flag in _sysconfigdata_*.py so all
distutils/setuptools based extension builds would break.  Rewrote this properly
for all pythonx.y packages.

As you submit more of this kind of patches for other packages, please keep these
patches as local as possible. And these flags are usually called CPPFLAGS, not
CCPFLAGS.

Matthias


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to