On Wed, Dec 21, 2005 at 05:35:21PM +0000, Hedi Berriche wrote:
>Just wondering whether
>
> * Remove DB_File version checks (closes: #340047, #343335)
>
>is the right way for fixing the reported bug. Indeed wouldn't be more
>appropriate to do the check only when $db_version is defined i.e. a patch along
>the following lines
>
>--- /scratch/DB_File.pm 2005-12-21 17:31:26.003833798 +0000
>+++ /scratch/DB_File.pm.new 2005-12-21 17:31:09.679786648 +0000
>@@ -268,7 +268,7 @@
>
> # make recno in Berkeley DB version 2 (or better) work like
> # recno in version 1.
>- if ($db_version > 1 and defined $arg[4] and $arg[4] =~ /RECNO/ and
>+ if (defined $db_version and $db_version > 1 and defined $arg[4] and
>$arg[4] =~ /RECNO/ and
> $arg[1] and ! -e $arg[1]) {
> open(FH, ">$arg[1]") or return undef ;
$db_version should be defined. If it's not, that's a problem, which
should not be masked by such a change.
I was of the impression that this was a side-effect of the failed
version check in ext/DB_File/version.c ... If the problem still occurs
with 5.8.7-10, please re-open the bug and I will investigate further.
--bod
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
