On 06/25/2015 08:27 PM, Zed Pobre wrote:
> On Thu, Jun 25, 2015 at 04:03:07PM +0200, Erwan Prioul wrote:
>> Source: libmodplug
>> Source-Version: 1:0.8.8.5-1
>> Tags: patch
>>
>> This light change enables the build for the ppc64el architecture.
>> Thanks for considering it.
> [...]
>> rm -f build-stamp configure-stamp
>> + rm -f config.guess config.sub
>> rm -f compile config.h.in config.log conftest conftest.o ltconfig
>> dh_clean
> 
> Well, I *can* do this, but I'm really curious about what's breaking.
> This change will delete two pre-existing files during the clean process
> that are modified during the build process.  What you end up with is
> still not what you started with, and the build process should
> overwrite them regardless.
> 
> Why is ppc64el breaking?  Is this something specific to an autobuilder?

The build on ppc64el ends like this:

configure: error: cannot guess build type; you must specify one
make: *** [configure-stamp] Error 1
checking build system type... debian/rules:17: recipe for target
'configure-stamp' failed

There is no entry for the ppc64el architecture in the config.sub and
config.guess files. The files aren't overwritten as expected during the
build process. That's why my patch removes them, kind of ugly way to get
recent version of these files.

I've reworked my patch (in attachment) to use
dh_autotools-dev_updateconfig and dh_autotools-dev_restoreconfig instead
of rm.

I hope this new patch is better than the previous one.

Regards,
Erwan.
Index: libmodplug-1:0.8.8.5-1/debian/rules
===================================================================
--- libmodplug-1:0.8.8.5-1/debian/rules
+++ libmodplug-1:0.8.8.5-1/debian/rules
@@ -15,8 +15,9 @@
 configure: configure-stamp
 configure-stamp:
 	dh_testdir
 
+	dh_autotools-dev_updateconfig
 	libtoolize --copy --force
 	aclocal
 	autoconf
 	autoheader
@@ -42,8 +43,9 @@
 	dh_testdir
 	test ! -f Makefile || $(MAKE) distclean
 	rm -f build-stamp configure-stamp
 	rm -f compile config.h.in config.log conftest conftest.o ltconfig
+	dh_autotools-dev_restoreconfig
 	dh_clean
 
 install: build
 	dh_testdir

Reply via email to