On Mon, Jun 15, 2015 at 02:58:39PM +0200, Piotr PaĆczyk wrote: > Hello again, > I did manage to apply those two commits manually: > https://github.com/chef/chef/commit/d99e497874e7d08f017376717aa38a4c8d7fecd5 > https://github.com/chef/chef/commit/6c10604f1e8e9b557b69449b484df3aae47ee468 > omitting a few lines related to some intermediate versions. > Forking is working correctly, the result is visualized in attached munin > grapph. I also attach the diff result. > > Such modified client has been used on about 80 servers for over 2 > months. The only problem I noticed is that if client run fails, the > stacktrace.out file only contains stacktrace from the parent process. > Child stacktrace is printed out to stderr (it's not included in logs, > visible only while executing the manual, single run). I've made some > custom modifications comparing files with chef 11.12, but I think the > result is not yet what we really expect. If you want to look at it, > please let me know.
I think that is a serious regression. If you manage to make it work correctly, please do get in touch and we can prepare a stable update for the memory leak. > If you decide to backport the package, I would suggest to add one small > feature (from newer versions) by chance - I really miss the file_edited? > method in Chef::Util::FileEdit. It's just one getter, the diff is also > attached. adding new features in a stable update is generally not a good idea, no matter what. -- Antonio Terceiro <terce...@debian.org>
signature.asc
Description: Digital signature