Package: libedit
Version: 3.1-20150325-1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu wily ubuntu-patch
Dear Maintainer,
libedit is failing to build in Wily (proposed) due to LIBBSD_LIBS being added
to LDFLAGS instead of LIBS.
As stated in
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
and
http://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Preset-Output-Variables.html#index-LDFLAGS-93
libraries must be added to LIBS instead of LDFLAGS.
*** /tmp/tmpCmy43w/bug_body
In Ubuntu, the attached patch was applied to achieve the following:
- fix build in Wily (proposed)
* debian/patches/libbsd.patch: use LIBS instead of LDFLAGS
Thanks for considering the patch.
-- System Information:
Debian Release: jessie/sid
APT prefers vivid-updates
APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'),
(100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.19.0-23-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru libedit-3.1-20150325/debian/changelog libedit-3.1-20150325/debian/changelog
diff -Nru libedit-3.1-20150325/debian/patches/libbsd.patch libedit-3.1-20150325/debian/patches/libbsd.patch
--- libedit-3.1-20150325/debian/patches/libbsd.patch 2015-04-28 04:51:33.000000000 -0300
+++ libedit-3.1-20150325/debian/patches/libbsd.patch 2015-07-29 14:38:41.000000000 -0300
@@ -1,21 +1,19 @@
-Index: libedit/configure.ac
-===================================================================
---- libedit.orig/configure.ac
-+++ libedit/configure.ac
-@@ -61,6 +61,12 @@ AC_CHECK_LIB(tinfo, tgetent,,
+--- a/configure.ac
++++ b/configure.ac
+@@ -61,6 +61,12 @@
)]
)
+PKG_CHECK_MODULES(LIBBSD, [libbsd-overlay],
+ [CFLAGS="$CFLAGS $LIBBSD_CFLAGS"
-+ LDFLAGS="$LDFLAGS $LIBBSD_LIBS"
++ LIBS="$LIBS $LIBBSD_LIBS"
+ MODULES="$MODULES libbsd"
+ AC_SUBST([MODULES])]
+)
### use option --enable-widec to turn on use of wide-character support
EL_ENABLE_WIDEC
-@@ -117,24 +123,32 @@ AC_PROG_GCC_TRADITIONAL
+@@ -117,24 +123,32 @@
#AC_FUNC_REALLOC
AC_TYPE_SIGNAL
AC_FUNC_STAT
