Control: tags -1 + patch

Hello!

I'm attaching a debdiff that should utilize the tmpfiles.d(5) feature
under systemd instead of using an init script to create the runtime
directory. (Completely untested.)

Special consideration to the case when the package gets removed
but not purged:
 - init script gets run again, but does nothing as it first checks binary
   existance
 - problematic $remote_fs dependency is reintroduced, but
   long-term systemd should drop rcS support and solve that.

While the supplied patch should give you a solution for the lintian
error "systemd-no-service-for-init-rcS-script", there are still room for
further improvement in the systemd integration of pidentd.
Right now pidentd relies on inetd for socket activation. This is a
feature which also systemd offers. You could ship a socket unit (see
systemd.socket(5)) and a matching service unit (see systemd.service(5))
and add systemd-sysv as an alternative to the inetd dependency. While
doing so you should also look into using the RuntimeDirectory= option in
the service file and drop the tmpfiles.d creation (ie. revert the
attached patch again). This could and should probably be handled in a
separate bug report though as using inetd should work perfectly fine
under systemd as well so this is not a blocker for eliminating the rcS
init script....

Regards,
Andreas Henriksson
diff -Nru pidentd-3.0.19.ds1/debian/changelog pidentd-3.0.19.ds1/debian/changelog
--- pidentd-3.0.19.ds1/debian/changelog	2011-12-08 03:03:44.000000000 +0100
+++ pidentd-3.0.19.ds1/debian/changelog	2015-08-23 18:26:44.000000000 +0200
@@ -1,3 +1,11 @@
+pidentd (3.0.19.ds1-7.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add debian/pidentd.tmpfile and debian/pidentd.links (Closes: #796689)
+    - create runtimedirectory using tmpfiles.d instead of via init-script.
+
+ -- Andreas Henriksson <[email protected]>  Sun, 23 Aug 2015 18:25:18 +0200
+
 pidentd (3.0.19.ds1-7) unstable; urgency=low
 
   * Fix update-rc.d error
diff -Nru pidentd-3.0.19.ds1/debian/pidentd.links pidentd-3.0.19.ds1/debian/pidentd.links
--- pidentd-3.0.19.ds1/debian/pidentd.links	1970-01-01 01:00:00.000000000 +0100
+++ pidentd-3.0.19.ds1/debian/pidentd.links	2015-08-23 18:34:46.000000000 +0200
@@ -0,0 +1 @@
+/dev/null /lib/systemd/system/pidentd.service
diff -Nru pidentd-3.0.19.ds1/debian/pidentd.tmpfile pidentd-3.0.19.ds1/debian/pidentd.tmpfile
--- pidentd-3.0.19.ds1/debian/pidentd.tmpfile	1970-01-01 01:00:00.000000000 +0100
+++ pidentd-3.0.19.ds1/debian/pidentd.tmpfile	2015-08-23 18:21:58.000000000 +0200
@@ -0,0 +1 @@
+d /var/run/identd 0755 identd nogroup - -

Reply via email to