On Wed, Aug 26, 2015 at 12:26 PM, Helmut Grohne <[email protected]> wrote:
> Control: user [email protected] > Control: usertags + rebootstrap > > Hi Ryan and Daniel, > > Thanks to Daniel for highlighting this bug to me. I know I'm being late > to the party, but let us please reconsider this stage before uploading. > > On Tue, Aug 25, 2015 at 12:51:56PM -0700, Ryan Tandy wrote: > > No hurry. Revised patch attached... I think it's correct, but would > > appreciate a thumbs-up when you have time. Thanks a lot for your help! > > I think that when adding a stage one should look further than just the > immediate cycle. This is the main reason that prevented me from > submitting a stage for openldap: I was lacking assurance that I was > doing it correctly. > > Given further testing I now have somewhat more confidence, so let me > propose a very different stage1: --disable-slapd > > Why does this make sense? This stage builds way less than the stage > proposed by Daniel. It also drops heimdal, but it also drops > cyrus-sasl2. Keep in mind that cyrus-sasl2 and openldap do have a direct > cycle that needs to be addressed in either cyrus-sasl2 or openldap. So > rather than add yet another stage to drop libsasl2-dev or add a stage to > cyrus-sasl2 dropping libldap2-dev, I therefore think that openldap's > stage1 should also drop the libsasl2-dev dependency. Turns out the > easiest way to do so is just not building the server. > > I am attaching my current stage1 for openldap for discussion. What do > you think? I don't have any objections - based on my experience, just libldap2-dev and dependencies are sufficient for progressing the bootstrap. On the other hand, I also have a cyrus-sasl2 bootstrap that also gets rid of krb5-multidev, libpq-dev, heimdal-multidev, libmysqlclient-dev, libkrb5-dev Build-Depends in addition to libldap2-dev; so unless you have a drastically different bootstrapping process that makes those dependencies available, I don't see it reducing the number of bootstrap builds needed. I also don't see your patch removing the openldap Build-Depends on libsasl2-dev. -- Daniel
