Source: getdns
Version: 0.3.1-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]

Hi dkg,

In debian/rules you attempt to call dpkg-parsechangelog (the program)
as follows:

  $(dpkg-parsechangelog

.. but the lack of any of:

  $(shell dpkg-parsechangelog

  `dpkg-parsechangelog

  $$(dpkg-parsechangelog

.. means that you are actually expanding a /variable/ called
"dpkg-parsechangelog" (!).

This results in passing an empty string to date(1)'s -d argument, which
results in the time rendered being set to midnight of the current
day (!!). The package doesn't appear to be unreproducible though, so the
value is likely not ending up in the final binary.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/rules      2015-08-28 16:41:51.621796895 +0100
--- b/debian/rules      2015-08-28 16:45:40.584797410 +0100
@@ -9,7 +9,7 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-CURRENT_DATE=$(shell date -u --rfc-3339=seconds --date "$(dpkg-parsechangelog 
--show-field Date)")
+CURRENT_DATE=$(shell date -u --rfc-3339=seconds --date "$(shell 
dpkg-parsechangelog --show-field Date)")
 
 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
 

Reply via email to