Control: reassign -1 icewm-common 1.3.8+githubmod+20150818+ad97152-1 Control: affects -1 + icewm
Let's play ping-pong ... On 2015-09-12 12:18, Eduard Bloch wrote: > * Sven Joachim [Sat, Sep 12 2015, 10:51:16AM]: >> Am 12.09.2015 um 09:43 schrieb Eduard Bloch: >>> * Andreas Beckmann [Fri, Sep 11 2015, 09:07:14PM]: >>>> a test with piuparts revealed that your package misses the copyright >>>> file, which is a violation of Policy 12.5: >>>> https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile >>>> >>>> >From the attached log (scroll to the middle...): >>>> >>>> 0m35.9s ERROR: WARN: Inadequate results from running adequate! >>>> icewm: missing-copyright-file /usr/share/doc/icewm/copyright >>>> >>>> # ls -la /usr/share/doc/icewm/ >>>> total 12 >>>> drwxr-xr-x 2 root root 60 Aug 22 21:34 . >>>> drwxr-xr-x 136 root root 2860 Aug 22 21:34 .. >>>> -rw-r--r-- 1 root root 8271 Aug 18 10:33 preferences.gz >>> >>> WTF? /usr/share/doc/icewm is a symlink to icewm-common and >>> >>> $ less icewm-common_1.3.8+githubmod+20150818+ad97152-1_amd64.deb | grep >>> copyright >>> -rw-r--r-- root/root 1695 2015-08-18 11:43 >>> ./usr/share/doc/icewm-common/copyright >>> >>> I checked more file contents lists, they all look fine. >>> https://packages.debian.org/unstable/icewm-common >> >> There is one thing which is _not_ fine, icewm-common inadvertently ships >> the file /usr/share/doc/icewm/preferences.gz, so if icewm-common is >> unpacked before icewm, /usr/share/doc/icewm ends up as a directory >> rather than a symlink. > > C'mon, seriously, what about understanding what I wrote? Yes, he did. But did you understand what Sven wrote? > Check: > https://packages.debian.org/sid/arm64/icewm-common/filelist That contains ... /usr/share/doc/icewm-common/html/icewm.html /usr/share/doc/icewm/preferences.gz /usr/share/icewm/README ... > and > https://packages.debian.org/sid/arm64/icewm/filelist > and this is a very legal symlink: > lrwxrwxrwx 1 root root 12 Jun 1 2009 /usr/share/doc/icewm -> icewm-common Except if /usr/share/doc/icewm already exists as a real directory, the symlink wont be created. to reproduce: * create a minimal sid chroot * apt-get install icewm-common * apt-get install icewm (you can even omit to install icewm-common first, the default ordering unpacks it before icewm) So the first bug is in icewm-common, shipping a file in the wrong location. Properly fixing this will require a dir_to_symlink transition in icewm, too. That's probably (and completely untested) * icewm: Conflicts: icewm-common (<< $FIXEDVERSION~) (yes, this will need a versioned Conflicts) * debian/icewm.maintscript: dir_to_symlink /usr/share/doc/icewm icewm-common $FIXEDVERSION~ Andreas