* Michael Banck <[EMAIL PROTECTED]> [2005-12-27 19:17]: > > noticed there's a -R/--rename option but this code is really a > > mess: -R doesn't actually do anything at all. And the internal > > freedb_rename variable (which has nothing to do with -R) is completely > > useless too: jack tries to do renames even when you don't use -Q/-q at > > all (i.e. just 'jack -t 1') and then fails: > > In my experience, using -R has its uses, namely if you modify > jack.freedb and want to rename/retag the files without querying > freedb.org again, and it seems to work mostly fine for me usually.
Sorry, I was confused when I wrote this. -R obviously does something; I use it myself from time to time. The rest of what I said is still true, though. > > (which don't actually do anything), got rid of -R/--rename (which > > again, doesn't do anything, and doesn't make sense since -Q/-q > > automatically renames). > > Does -Q/-q recognize whether the computer is online and/or fail > gracefully if not these days? Not sure, I'll check later. > Does it make sense to not rename directories while renaming files, or > vice-versa? I'm not sure. I personally don't think so. > I think the underlying problem is that --rename really is not much of an > option (I mean, if you queried and now have an freedb entry available, > why wouldn't you want to have your files renamed?) but rather an action > (which is, granted, executed automatically most of the time). Well, maybe it should changed to be a proper option rather than an action. Then it could default to yes (and deal with the fact when no jack.freedb file exists) and people could turn it off. > One way out of this (or maybe I'm trying to solve a problem which isn't > there, correct me if I'm wrong) would be to have a couple of different > executables which do several actions: jack-rip, jack-query, jack-tag > (where the last implies renaming and tagging). The regular jack would > be a "just works, do whatever needs to be done for the current I'm not sure this is such a good idea. It's again the whole "ripping/encoding/tagging with one command" idea. I think passing options to jack to tell it what to do is okay; then again, jack could call jack-rip, jack-query, etc; however, that's not a change we can make without Arne. Anyway, I'll think of this some more later. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
