Hi Gianfranco, Thanks for the review! Good idea about using the *FLAGS env vars. I've updated the patch to use those and will also propose the change to upstream. I've also added back -Wall as suggested. The package has just been reuploaded to mentors.
Best regards, Andy On Thu, Sep 24, 2015 at 5:54 PM, Gianfranco Costamagna < costamagnagianfra...@yahoo.it> wrote: > Hi Andy, > > > > the packaging looks good. > > I did two builds with DH_VERBOSE=1 in a sid chroot > (the unstable and mentors versions) > > I did a meld between them, and I see some "issues" > > -"Wall" flag has disappeared > > (I guess not a real problem here :) ) > > > - many lines are like this one > gcc -O3 -DEAPI -fPIC -pthread $(pkg-config --cflags apr-1) -pthread > $(dpkg-buildflags --get CFLAGS) -c -I../../vm -I/usr/include/mysql mysql.c > > evaluating $(dpkg-buildflags --get CFLAGS) at each file build (and link, > the same is for LDFLAGS) is somewhat an overkill. > > I see they come from debian/patches/harden.patch, > just as TODO you might ask upstream to use *FLAGS from the environment, > and drop that patch. > > > but we are nitpicking here :) > > So if you can readd the -Wall flag I guess we are fine there :) > > cheers, > > G. >
