Thanks Piotr,
One quick comment can be found inline below.
On 10/19/2015 11:54 PM, Piotr Ożarowski wrote:
Hi Ross,
[Ross Gammon, 2015-10-19]
-XS-Python-Version: all
-Build-Depends: debhelper (>= 5), python (>= 2.3.5-11), python-all-dev
-Build-Depends-Indep: python-setuptools, python-support (>= 0.6.4)
+X-Python-Version: >= 2.3.5-11
please use 'X-Python-Version: >= 2.3', this field is about upstream
Python version, not really about our interpreter version
+Build-Depends: debhelper (>= 5), python, python-all-dev
+Build-Depends-Indep: python-setuptools, dh-python
that's OK, we don't need versioned python anymore, but it's NMU, so
better leave it as it was
Standards-Version: 3.8.1
Vcs-Git: git://git.geekbu.de/python-flickrapi/
Vcs-Browser: http://git.geekbu.de/?p=python-flickrapi.git
diff -u python-flickrapi-1.2/debian/rules python-flickrapi-1.2/debian/rules
--- python-flickrapi-1.2/debian/rules
+++ python-flickrapi-1.2/debian/rules
@@ -1,14 +1,11 @@
#!/usr/bin/make -f
-PYVERS=$(shell pyversions -r)
d=debian/python-flickrapi
build:
clean:
dh_testdir
- for python in $(PYVERS); do \
- $$python setup.py clean; \
- done
+ python setup.py clean
rm -f `find $(CURDIR) -name '*.pyc'`
rm -rf build-stamp build
rm -rf $(d)
@@ -20,9 +17,7 @@
dh_testroot
dh_installdirs
set -e; \
- for python in $(PYVERS); do \
- $$python setup.py install --root=$(d) --prefix=/usr ;\
- done
+ python setup.py install --root=$(d) --prefix=/usr
binary-indep: build install
dh_testdir
@@ -31,7 +26,7 @@
dh_installchangelogs
dh_compress -X.py
dh_fixperms
please remove these changes, they're not related to pysupport removal
I found I had to make these changes to get it to build because it was
picking up NULL for the PYVERS. But maybe if I make the other changes
you suggest, the problem will be solved for me (or I will come back for
more help).
- dh_pysupport
+ dh_python2
this one is perfectly valid
PS thanks for you work!
Cheers,
Ross
