Package: goaccess
Version: 1:0.9.4-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
First, thanks for maintaining this great log analyzer.
While working on the "reproducible builds" effort [1], we have
noticed that goaccess could not be built reproducibly [2].
The attached patch removes extra timestamps from the build system when
creating the source archive. Once applied, goaccess can be built
reproducibly in our current experimental framework.
[1]: https://wiki.debian.org/ReproducibleBuilds
[2]: https://reproducible.debian.net/rb-pkg/unstable/amd64/goaccess.html
- -- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-50-generic (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
Versions of packages goaccess depends on:
ii libc6 2.19-22
ii libgeoip1 1.6.6-1+b1
ii libglib2.0-0 2.46.1-1
ii libncurses5 6.0+20151024-1
ii libtinfo5 6.0+20151024-1
goaccess recommends no packages.
goaccess suggests no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWN+dRAAoJEJmGUYuaqqClP8wP/jCUutSvyVs+p4sAhzQcAcuS
5K5L2WsCy+y4hrdK0YT02894UI6YJwMIYU90nJhUc4I3oNldRT+XG729ZIRsuSLg
ogeKCZ9mgo30LLOgZng3GfvLKO2vQndgOweiXoCKHMTxi+C2UpbdOoJrM3ORxMOU
cFsrnUFsLSY0mfdRCNvJ7s7prpXKywXMSOhrteH2lXAvr4BRaQIQQsmvRFlOTwS4
2JxeDoWIDmCX7c14OihiEOqOVsp6v6MbtNnB+TJ1ozCxtNh1OPvyrX7cix6z+F3o
g/bWXI1oxei6Yy3E+kWHlPl4ekeqq3BS92lcKF5Mj1SgkguCG4ENX3ro+rRrsK5X
eVoyXWXf/y6aQiQxMIHhd32yZ8ZMzktTRuqb+P+tyQXXMCtRRwDNejLMmA5I2NZn
gfd4kiYlFQCcRkI9JMZiEKXcdAsZDWAGJWHSDtJZiGJveMWfc4K2YlIMr+3bTrfy
4rldXjvsCGMezfDQ7YCUKf/0yUKoi52cKzGDSA7ZSnzwMQlNpJ9r75yJxaaQ4Fcp
jXqpPjF4M+jRuB6bKMZENieSrY8K3zbqKhgPUYDrojIqgLOU6O65K27QXD8o/Bi8
E+gFM8GBBl3gs5JVTHMDmlqM24MQts64p/zJdmFikR7Y04BMr+NU1ngEjXXKuIzY
9a1SfBMV97d2dO0jBQHk
=BNoM
-----END PGP SIGNATURE-----
diff -Nru goaccess-0.9.4/debian/changelog goaccess-0.9.4/debian/changelog
--- goaccess-0.9.4/debian/changelog 2015-10-06 18:19:20.000000000 +0200
+++ goaccess-0.9.4/debian/changelog 2015-11-02 23:25:03.000000000 +0100
@@ -1,3 +1,10 @@
+goaccess (1:0.9.4-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Enable reproducible build by removing use of __{DATE,TIME}__ in src/error.h
+
+ -- Guillaume Delacour <[email protected]> Mon, 02 Nov 2015 23:23:17 +0100
+
goaccess (1:0.9.4-1) unstable; urgency=medium
* New upstream release.
diff -Nru goaccess-0.9.4/debian/patches/reproducible_build.patch goaccess-0.9.4/debian/patches/reproducible_build.patch
--- goaccess-0.9.4/debian/patches/reproducible_build.patch 1970-01-01 01:00:00.000000000 +0100
+++ goaccess-0.9.4/debian/patches/reproducible_build.patch 2015-11-02 23:28:33.000000000 +0100
@@ -0,0 +1,18 @@
+From: Guillaume Delacour <[email protected]>
+Description: Remove unnecessary use of __{DATE,TIME}__ macros
+Last-Update: 2015-11-02
+
+Index: goaccess-0.9.4/src/error.h
+===================================================================
+--- goaccess-0.9.4.orig/src/error.h
++++ goaccess-0.9.4/src/error.h
+@@ -41,8 +41,7 @@
+
+ #define FATAL(fmt, ...) do { \
+ (void) endwin (); \
+- fprintf (stderr, "\nGoAccess - version %s - %s %s\n", GO_VERSION, __DATE__, \
+- __TIME__); \
++ fprintf (stderr, "\nGoAccess - version %s\n", GO_VERSION); \
+ fprintf (stderr, "Config file: %s\n", conf.iconfigfile ?: NO_CONFIG_FILE); \
+ fprintf (stderr, "\nFatal error has occurred"); \
+ fprintf (stderr, "\nError occured at: %s - %s - %d\n", __FILE__, \
diff -Nru goaccess-0.9.4/debian/patches/series goaccess-0.9.4/debian/patches/series
--- goaccess-0.9.4/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ goaccess-0.9.4/debian/patches/series 2015-11-02 23:25:34.000000000 +0100
@@ -0,0 +1 @@
+reproducible_build.patch