Am Mittwoch, den 04.11.2015, 11:36 +1100 schrieb Joe Healy: > > > On Tue, Nov 3, 2015 at 11:17 PM, Benjamin Drung < > benjamin.dr...@profitbricks.com> wrote: > > Hi Joe, > > > > I pushed the current state. May you review these changes? > > Those changes all look good. > > I understand the rationale for removing the "Debian Source Package" > from the reproducible builds patch, but what are your thoughts on > continuing to report the package version in the versions report? Ie > including the "Debian Source Package" reporting in its own patch? > > Although it is less useful for "pure" debian machines, it is very > helpful in dealing with issues when people think they are running > from source/packages or have installed packages from the wrong > os/release.
Reporting the Debian package version in the version report is useful, but I didn't like that it was bundled to the reproducible patch and how it was implemented. So the quick solution was to just remove that part from the patch. I have nothing against adding it back as separate patch. I would prefer an implementation that is upstreamable. So the vendor and package version should be injected via setup parameter (e.g. ./setu p.py --vendor Debian --package-version 2015.8.1+ds-1). Then other distributions could reuse it. > > I want to run "wrap-and-sort" and add a ".patch" suffix to all > > patches. > > Any objections to that? > > > > > Sounds good - I was never aware of the wrap and sort tool. Looks > useful. Great. Pushed. -- Benjamin Drung System Developer Debian & Ubuntu Developer ProfitBricks GmbH Greifswalder Str. 207 D - 10405 Berlin Email: benjamin.dr...@profitbricks.com URL: http://www.profitbricks.com Sitz der Gesellschaft: Berlin. Registergericht: Amtsgericht Charlottenburg, HRB 125506B. Geschäftsführer: Andreas Gauger, Achim Weiss.