On Thu, Nov 12, 2015 at 7:14 PM, Andreas Cadhalpun < andreas.cadhal...@gmail.com> wrote:
> Hi Bret, > > On 11.11.2015 09:04, bret curtis wrote: > > thanks for the revamped patch. I massaged it a bit to work upstream and > tested it, it works for me on Debian and Ubuntu. > > Great! > Indeed, it looks like we'll get it in for 0.37 which should drop in a few days as we are in the RC phase. I had to modify the patch a bit further to handle duplicate and bad packets correctly and drop our libav compatibility wrapper. Thank you again for pushing us in the right direction. ;) > > > It does however break compatibility with older ffmpegs and other distros > which we need to support. Any way we can work around this? > > You could use some ifdeffery, e.g. for AV_PIX_FMT_*: > #if LIBAVUTIL_VERSION_MAJOR > 51 > > The library/version to use can be found in ffmpeg's APIchanges [1]. > Though, all of these changes should be compatible with any FFmpeg version > since 2.0, > and using older versions isn't really a good idea. > We made the decision to just drop libav since only Debian/Ubuntu supported it, and since libav is now being dropped we figured now is the moment to do the same. The only problem was our OSX builds that were still using 1.2.4 (and worked), and the packager said it wouldn't be a problem to use a release >= 2.0. This means that we are +20 −282 of 302 lines changed in the PR here: https://github.com/OpenMW/openmw/pull/800 So I'll mark this bug (and others) closed when 0.37 is released. Thanks again! Cheers, Bret
