On Wed, 2006-01-04 at 09:33 -0500, Justin Pryzby wrote: > > > Packages for which this is a false-positive (such as slash, gnudip, > > > and bake) > > > > These can be eliminated by checking for a url in the description too. > > It reduces some true positives also: abcmidi, achims-guestbook, > airsnort, alsa-base, anjuta, ant, apache, apg, ardour-doc, aspell-bg, > atlc, audacity, etc.
airsnort anjuta apg aspell-bg ant apache atlc audacity: are detected by my last-line-has-url-isn't-homepage test. abcmidi achims-guestbook alsa-base: Perhaps I can extend my test to take into account the last paragraph (merged into one line) instead of the last line. ardour-doc: I should add the phrase "further information" to your test. added. > > How about the attached combination check - does my check and also does > > yours, with the changes that it checks a couple of other words, and > > checks for a url in the description too. > > > $description =~ m/(homepage|webpage|website)/is > Good, please also add "|URL|upstream" Added, along with some other phrases I found. > (see asterisk-sounds-extra). That would have been caught by my last-line-has-url-isn't-homepage test. > > && $description =~ m/[a-z]+:\/\// > This is to reduce false positives, right? I don't like it. If this > were an ' || ' condition, it would be great. If it were an || then any package with a URL in the description would trigger the test, which is probably a bad idea, because not all URLs will be homepages. > Or is the contents of this "description" variable the control field > without the first column of blanks? I guess that is probably it. Correct. I'll add the "last-para instead of last-line" change and then send an updated patch. Of course, all this would be simpler if there was a Homepage field. -- bye, pabs http://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
