Control: forwarded -1 https://github.com/johnkerl/miller/issues/87
Hi Edmund, On Fri, 20 Nov 2015 10:51:26 +0000, Edmund Grimley Evans <[email protected]> wrote: > It failed to build on many architectures: > > http://buildd.debian.org/status/package.php?p=miller&suite=sid > > In some cases the error was: > > FAIL: test_peek_file_reader > > I noticed this line of code in there: > > mu_assert_lf(pfr_peek_char(pfr) == EOF); > > But pfr_peek_char is declared to return char. If you want that and > other functions to return EOF as a special value then they must be > declared to return int, like getchar or fgetc, which "reads the next > character from stream and returns it as an unsigned char cast to an > int, or EOF on end of file or error". > > EOF is negative. On some architectures plain char is unsigned. Thanks for the investigation, I'm forwarding this to the corresponding upstream issue. Regards, Stephen
pgpwAaZjfvoi3.pgp
Description: OpenPGP digital signature
