On Sat, Aug 29, 2015 at 12:15:16PM +0200, Egmont Koblinger wrote:
> Hi,
Hi,
[..]
> - The big piece is spawning a process for the terminal, and here my
> patch is definitely incomplete as it'd require more thorough
> understanding of the code:
>
> -- argv needs to be populated with the command to be launched
> -- the possible pty flags and spawn should be carefully revised
> -- I _think_ that whatever happened so far between the
> vte_whatever_fork() and the exec() [now I replaced vte_whatever_fork()
> by vte_whatever_spawn(), but I haven't traced down where the exec()
> happens], which I believe is probably what DoInstallPostFork() does,
> needs to be moved into the child_setup method of vte_whatever_spawn().
> It's going to be a bit of refactoring.
[..]
Thanks for your initial patch. I finally managed to look at this issue
and I updated the code. It was a bit tricky as synaptic really needs
forkpty() instad of spawn_{,a}sync support. But that should work
now. If you have time it would be awsome to test the latest git.
Cheers,
Michael
