control: retitle -1 wine: test if multiarch is enabled fails with multiple foreign archs control: tags -1 + pending
On 02/23/2015 09:38 AM, Erik de Castro Lopo wrote: > a) On amd64 if fails when there more than one foreign-achitecture > installed. [...] > b) The current script does not seamlessly handle both 32 and 64 bit > binaries. b) is also reported in e.g. #769234 (automatically detect and launch wine32 or wine64). Your patch for it imo is to strict, I've come up with another version in #769234. I'd suggest that we followup there for b). Your proposed patch for a) [1] does not work for people with kfreebsd-i386 or hurd-i386 but no i386 as foreign-arch. I've committed a fixed version with "-x" added to match whole lines. On 04/02/2015 09:24 AM, Erik de Castro Lopo wrote: > Each time the wine package gets upgraded, I have to manually re-apply > this patch. It I don't, the tests for the 64 bit Windows build will > fail. Do the tests fail if you get any output? Because the code of issue a) is only output, not an error/exit. Or did I miss something? Greets jre [1] Relevant part from your patch: - if [ "$(dpkg --print-architecture)" = "amd64" -a "$(dpkg --print-foreign-architectures)" != "i386" ]; then + if [ "$(dpkg --print-architecture)" = "amd64" -a "$(dpkg --print-foreign-architectures | grep -c "i386")" -ne 1 ]; then