Package: rsyslog
Version: 8.4.2-1+deb8u1
Severity: important
Tags: patch
Hi,
We experienced dying rsyslogd processes. It seems to often be at
midnight, or shortly afterwards, when a lot of files are being created,
due to the dynamic naming of per-host/per-day files. We found upstream
commit [1] that matches our symptoms. After applying this patch,
rsyslogd has been running stable. So please apply this patch for jessie
(a debdiff for that is attached). stretch/unstable are not affected since
this upstream commit is part of rsyslog 8.12.0.
Thanks.
[1]
https://github.com/rsyslog/rsyslog/commit/008f0097b610742595034cdab381749dbc00f93f
--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Email: benjamin.dr...@profitbricks.com
URL: http://www.profitbricks.com
Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
Geschäftsführer: Andreas Gauger, Achim Weiss.
diff -Nru rsyslog-8.4.2/debian/changelog rsyslog-8.4.2/debian/changelog
--- rsyslog-8.4.2/debian/changelog 2015-08-29 15:39:00.000000000 +0200
+++ rsyslog-8.4.2/debian/changelog 2015-12-14 13:15:08.000000000 +0100
@@ -1,3 +1,10 @@
+rsyslog (8.4.2-1+deb8u2) jessie; urgency=medium
+
+ * Prevent a segfault in dynafile creation. Patch cherry-picked from
+ upstream Git.
+
+ -- Benjamin Drung <benjamin.dr...@profitbricks.com> Mon, 14 Dec 2015 13:14:54 +0100
+
rsyslog (8.4.2-1+deb8u1) jessie; urgency=medium
* Disable transactions in ompgsql as they were not working properly.
diff -Nru rsyslog-8.4.2/debian/patches/0003-Prevent-a-segfault-in-dynafile-creation.patch rsyslog-8.4.2/debian/patches/0003-Prevent-a-segfault-in-dynafile-creation.patch
--- rsyslog-8.4.2/debian/patches/0003-Prevent-a-segfault-in-dynafile-creation.patch 1970-01-01 01:00:00.000000000 +0100
+++ rsyslog-8.4.2/debian/patches/0003-Prevent-a-segfault-in-dynafile-creation.patch 2015-11-19 11:11:18.000000000 +0100
@@ -0,0 +1,25 @@
+From 008f0097b610742595034cdab381749dbc00f93f Mon Sep 17 00:00:00 2001
+From: Tomas Heinrich <thein...@redhat.com>
+Date: Fri, 17 Jul 2015 21:00:23 +0200
+Subject: [PATCH] Prevent a segfault in dynafile creation
+
+A failure during the dynafile creation (in prepareFile(), most of the
+time) led to a misaddressing and a segfault.
+
+(cherry-picked from commit 008f0097b610742595034cdab381749dbc00f93)
+---
+ tools/omfile.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/tools/omfile.c
++++ b/tools/omfile.c
+@@ -779,7 +779,8 @@
+ DBGPRINTF("Added new entry %d for file cache, file '%s'.\n", iFirstFree, newFileName);
+
+ finalize_it:
+- pCache[pData->iCurrElt]->nInactive = 0;
++ if(iRet == RS_RET_OK)
++ pCache[pData->iCurrElt]->nInactive = 0;
+ RETiRet;
+ }
+
diff -Nru rsyslog-8.4.2/debian/patches/series rsyslog-8.4.2/debian/patches/series
--- rsyslog-8.4.2/debian/patches/series 2015-08-29 15:39:00.000000000 +0200
+++ rsyslog-8.4.2/debian/patches/series 2015-11-19 11:10:21.000000000 +0100
@@ -1,2 +1,3 @@
0001-Don-t-create-a-database.patch
0002-bugfix-ompgsql-transaction-were-improperly-handled.patch
+0003-Prevent-a-segfault-in-dynafile-creation.patch
