tags 793358 pending thanks On Sun, Dec 20, 2015 at 01:42:37PM +0100, Samuel Thibault wrote: > > Upstream don't want to carry the patch as they can't test it, > > Well, the thing is: it does not even make *sense* to define _GNU_SOURCE > after having included headers!...
To be fair to them, I didn't give them any details. I only mentioned a Hurd-specific patch as I hadn't thought too much about it. > > But then I noticed that _GNU_SOURCE is alreadying being set in the > > current "hurd.patch" quilt patch. Is the current patch no longer > > working? Can it be updated or removed? > > Apparently this is due to something new in the dh_auto_clean rule: > > rm -f cmake/os/GNU.cmake > > Since that's invoked between applying quilt patches and the build, then > hurd.patch's GNU.cmake has no effect indeed. > > Also, I see that dh_auto_clean removes the .pc directory. This > is really not how things are working with quilt patches: yes, > ./debian/rules clean does not unapply patches, that's how it works: one > has to run dh_quilt_unpatch after that, and then the .pc directory and > GNU.cmake files will have disappeared. > > Please apply the attached patch to fix it. Thanks. It turns out that this was a regression caused by Bjoern's "clean up" commits, so I've reverted them. Robie
signature.asc
Description: Digital signature
