Control: tag -1 + pending Hi,
On Thu, 24 Dec 2015 02:36:24 +0000 Wookey <[email protected]> wrote: > +++ Johannes Schauer [2015-12-24 01:07 +0100]: > > unfortunately the current synopsis of sbuild-createchroot is: > > > > sbuild-createchroot [...] SUITE TARGET-DIRECTORY DEBIAN-MIRROR-URI > > > > If tarball creation were to become the default, then the TARGET-DIRECTORY > > positional argument would become a tarball path instead. Would this not > > break > > backwards compatibility with users/scripts assuming that this argument is a > > directory? It is even assumed to be a directory when adding the > > --make-sbuild-tarball option. > > > > So how about doing this instead: > > > > - promote the --make-sbuild-tarball option more in the EXAMPLES section of > > the > > sbuild-createchroot man page as it is already done in the sbuild wiki > > page. > > > > - when creating a directory based schroot, add union-type=overlay option by > > default > > > > What do you think? > > I think that would certianly be an improvement and agree that it would > avoid incompatible/confusing changes. > > I'm not sure how much of a problem changing the meaning of that param > from dir to tarball-basename actually is in practice. Perhaps it would > still be worth it, to get a 'better' default. Doing it at t ime when > lots of sbuild things are changing anyway might make sense... > > But I'm OK with taking the compatible route for now as that's easier and > won't break anything. attached patch is in my local git, should fix this bug and should be part of the next sbuild release. Thanks! cheers, josch
From a7a639d76a007147fb688bd941d736ebf3828d87 Mon Sep 17 00:00:00 2001 From: Johannes 'josch' Schauer <[email protected]> Date: Fri, 25 Dec 2015 12:36:24 +0100 Subject: [PATCH] sbuild-createchroot: use union-type=overlay for directory chroot and promote tarball chroot in the manpage (closes: #751732) --- bin/sbuild-createchroot | 1 + man/sbuild-createchroot.8.in | 16 ++++++++-------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/bin/sbuild-createchroot b/bin/sbuild-createchroot index 5ef7ad4..da085b0 100755 --- a/bin/sbuild-createchroot +++ b/bin/sbuild-createchroot @@ -298,6 +298,7 @@ EOF $config_entry = <<"EOF"; [$chrootname] type=directory +union-type=overlay description=Debian $suite/$arch autobuilder directory=$target groups=root,sbuild diff --git a/man/sbuild-createchroot.8.in b/man/sbuild-createchroot.8.in index dcd6083..25e4996 100644 --- a/man/sbuild-createchroot.8.in +++ b/man/sbuild-createchroot.8.in @@ -186,13 +186,6 @@ Generates a compressed tarball using xz. If no extension is specified, sbuild\-createchroot will rename \fIfile\fP to \fIfile.tar.gz\fP and generate \fIfile.tar.gz\fP as a compressed tarball using gzip. .SH EXAMPLES -To create a plain type sid (unstable) chroot in \fI/srv/chroot/unstable\fP using -the \fIhttpredir.debian.org\fP Debian http mirror redirector service: -.PP -\f[CR]% \f[CB]sudo sbuild\-createchroot sid /srv/chroot/unstable \fP\fP\\ -.br -\f[CB] http://httpredir.debian.org/debian\fP\[CR] -.PP To create a bootstrapped file type sid (unstable) chroot ready for use with sbuild and saved in \fI/var/cache/sbuild/sbuild.tar.gz\fP using the \fIhttpredir.debian.org\fP Debian http mirror redirector service and using a @@ -200,11 +193,18 @@ temporary directory as the target: .PP \f[CR]% \f[CB]sudo sbuild\-createchroot \fP\fP\\ .br - \-\-make\-sbuild\-tarball=/var/cache/sbuild/sbuild.tar.gz \fP\fP\\ + \-\-make\-sbuild\-tarball=/srv/chroot/unstable-amd64.tar.gz \fP\fP\\ .br sid `mktemp \-d` \fP\fP\\ .br \f[CB] http://httpredir.debian.org/debian\fP\[CR] +.PP +To create a plain type sid (unstable) chroot in \fI/srv/chroot/unstable\fP using +the \fIhttpredir.debian.org\fP Debian http mirror redirector service: +.PP +\f[CR]% \f[CB]sudo sbuild\-createchroot sid /srv/chroot/unstable-amd64 \fP\fP\\ +.br +\f[CB] http://httpredir.debian.org/debian\fP\[CR] .SH HISTORY sbuild\-createchroot was previously known as \fBbuildd.chroot\fP. buildd.chroot performed exactly the same tasks, but additionally created a -- 2.5.1
signature.asc
Description: signature
