Source: recoll
Version: 1.21.0-1
Severity: important
Tags: patch

Currently recoll only builds support for the default python3
version.  As a result, once the default version switches from python3 3.4 to
3.5, python3-recoll will be unusable until it can be rebuilt.  The
best practice (as described in the Debian Python policy) is to build for all
supported versions.  Then whichever is default, the package still works.

Please see the attached patch (formatted as an NMU because that's what
devscripts handed me, but I have no near term plans to NMU).

Scott K
diff -Nru recoll-1.21.0/debian/changelog recoll-1.21.0/debian/changelog
--- recoll-1.21.0/debian/changelog	2015-08-03 08:46:47.000000000 +0000
+++ recoll-1.21.0/debian/changelog	2015-12-31 02:40:21.000000000 +0000
@@ -1,3 +1,13 @@
+recoll (1.21.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add support for building for all supported python3 versions (this is a
+    better solution than the one proposed in #793636
+    - Change python3-dev build-dep back to python3-all-dev
+    - Add loop over supported python3 versions to install rule
+
+ -- Scott Kitterman <[email protected]>  Thu, 31 Dec 2015 02:37:10 +0000
+
 recoll (1.21.0-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru recoll-1.21.0/debian/control recoll-1.21.0/debian/control
--- recoll-1.21.0/debian/control	2015-08-03 08:46:15.000000000 +0000
+++ recoll-1.21.0/debian/control	2015-12-31 02:37:06.000000000 +0000
@@ -13,7 +13,7 @@
                libxapian-dev (>= 1.2.0),
                libz-dev,
                python-dev (>= 2.6.6-3~),
-               python3-dev
+               python3-all-dev
 X-Python-Version: >= 2.7
 Vcs-Git: git://anonscm.debian.org/collab-maint/recoll.git
 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/recoll.git;a=summary
diff -Nru recoll-1.21.0/debian/rules recoll-1.21.0/debian/rules
--- recoll-1.21.0/debian/rules	2015-03-30 08:40:42.000000000 +0000
+++ recoll-1.21.0/debian/rules	2015-12-31 02:36:46.000000000 +0000
@@ -15,6 +15,8 @@
 CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS) $(CPPFLAGS)
 LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)
 
+build3vers := $(shell py3versions -sv)
+
 #build qt4 UI only
 export QMAKE=qmake-qt4
 
@@ -59,9 +61,11 @@
 	(cd python/recoll; python setup.py install \
 	                                   --install-layout=deb \
 	                                   --prefix=$(CURDIR)/debian/tmp/usr )
-	(cd python/recoll; python3 setup.py install \
+	set -e && for i in $(build3vers); do \
+	  (cd python/recoll; python$$i ./setup.py install \
 	                                   --install-layout=deb \
-	                                   --prefix=$(CURDIR)/debian/tmp/usr )
+	                                   --prefix=$(CURDIR)/debian/tmp/usr ) ; \
+	done
 
 binary-arch: build install
 	dh_testdir

Reply via email to