Bug#803861: spek: FTBFS with FFmpeg 2.9

[Andreas Cadhalpun]

Hi Alexander,

On 11.01.2016 03:49, Alexander Kojevnikov wrote:
> On Sun, Jan 10, 2016 at 2:14 AM, Andreas Cadhalpun
> <andreas.cadhal...@googlemail.com> wrote:
>>
>> [...]
>>
>>> feel free to update and NMU the Debian package.
>>
>> I think it would be better if you made a maintainer upload,
>> as the package otherwise looks a bit unmaintained with only
>> two NMUs in the last two years...
>> (I'm sure Felipe Sateler would be willing to sponsor such an upload,
>> like he did for dvbcut[1].)
> 
> Felipe, could you sponsor the upload? It's on m.d.n:
> http://mentors.debian.net/package/spek

Thanks for preparing the upload. I confirm that it builds with FFmpeg
from git master.

There are two things that would be nice to get fixed, though:
 * obsolete-url-in-packaging: The watchfile should use github instead
   of the obsolete code.google.com.
 * FFmpeg upstream introduced new deprecations in git master,
   in particular deprecating av_free_packet in favor of av_packet_unref.
   Since the replacement has been available already since quite some
   time (libavcodec 55.25.100 / 55.16.0) it would be nice if you
   would use it. That way spek should be API compatible with FFmpeg
   for at least the next two years. Patch:
--- spek-0.8.2.orig/src/spek-audio.cc
+++ spek-0.8.2/src/spek-audio.cc
@@ -224,7 +224,7 @@ AudioFileImpl::~AudioFileImpl()
         this->packet.data -= this->offset;
         this->packet.size += this->offset;
         this->offset = 0;
-        av_free_packet(&this->packet);
+        av_packet_unref(&this->packet);
     }
     if (this->format_context) {
         if (this->audio_stream >= 0) {
@@ -299,7 +299,7 @@ int AudioFileImpl::read()
             this->packet.data -= this->offset;
             this->packet.size += this->offset;
             this->offset = 0;
-            av_free_packet(&this->packet);
+            av_packet_unref(&this->packet);
         }
 
         int res = 0;
@@ -307,7 +307,7 @@ int AudioFileImpl::read()
             if (this->packet.stream_index == this->audio_stream) {
                 break;
             }
-            av_free_packet(&this->packet);
+            av_packet_unref(&this->packet);
         }
         if (res < 0) {
             // End of file or error.

Best regards,
Andreas