Hi Aaro, Andrew wrote > On Sun, Jan 17, 2016 at 11:55:19PM -0800, Rick Thomas wrote: >> >> On Jan 17, 2016, at 2:42 PM, Martin Michlmayr <t...@cyrius.com> wrote: >>> * Andrew Lunn <and...@lunn.ch> [2016-01-10 16:38]: >>>> Please can you try the following patch. If this works, i can add it to >>>> mainline. The issue we might run into is that somebody else wants >>>> serial not MMC.... >> >> Is it possible to make this depend on a DTB setting? e.g. the >> mainline kernel supports either serial or mmc, but which one depends >> on which one is configured in the DTB? > > Hi Rick > > Device tree is not particularly good for dynamic hardware. We would > probably have to have two device tree blobs, one for MMC and one for > RS232. I don't remember if this is just an issue for Base, or if > Client and Ultimate have the same muxing. If so, we would want two DT > blobs for those as well... > > If there is demand, we can do it, but i would prefer to avoid this if > possible. > > Andrew
Andrew wrote: > On Mon, Jan 18, 2016 at 02:49:50PM -0800, Martin Michlmayr wrote: >> * Rick Thomas <rbtho...@pobox.com> [2016-01-18 14:45]: >>> Would it be reasonable to put a note in the release docs (or in >>> /usr/share/doc/??? ) describing how to modify the released dtb for personal >>> use? >> >> Oh, right, I was going to make that comment but I forgot. >> >> Andrew: maybe instead of removing the code from the base DTB, you >> should comment it out and add a comment about this. This way, people >> can easily edit the DTS and recompile the DTB if needed. > > I was going to take Aaro Koskinen patches, since they have Tested-by: > etc. > > How about you ask Aaro to add the comment? > > Thanks > Andrew As per the above discussion, would it be possible to have the patch comment the code, rather than delete it, so that people with a need for the serial port could activate it? Maybe also add a note in the /usr/share/doc/ as to how to perform the activation. As long as both are possible, my own preference would be to have the MMC be default and the serial port be optional. But YMMV. I'll be more than happy to test any changes... Thanks! Rick
